Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win_copy - fix remote dir copy when it contains an empty dir #50126

Merged
merged 1 commit into from
Dec 19, 2018
Merged

win_copy - fix remote dir copy when it contains an empty dir #50126

merged 1 commit into from
Dec 19, 2018

Conversation

jborean93
Copy link
Contributor

SUMMARY

When using win_copy to copy a remote directory that contains an empty directory it will fail when getting the size. This PR changes the logic to better handle empty directories.

Fixes #50077

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_copy

@ansibot
Copy link
Contributor

ansibot commented Dec 19, 2018

cc @dagwieers @jhawkesworth @nitzmahone
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community labels Dec 19, 2018
@jborean93 jborean93 merged commit 65ce1b7 into ansible:devel Dec 19, 2018
@jborean93 jborean93 deleted the win_copy-empty-dir branch December 19, 2018 04:55
jborean93 added a commit to jborean93/ansible that referenced this pull request Dec 19, 2018
@jborean93
win_copy - fix remote dir copy when it contains an empty dir (ansible…
ef4d465 
…#50126)

(cherry picked from commit 65ce1b7)
jborean93 added a commit to jborean93/ansible that referenced this pull request Dec 19, 2018
@jborean93
win_copy - fix remote dir copy when it contains an empty dir (ansible…
b0ec0da 
…#50126)

(cherry picked from commit 65ce1b7)
This was referenced Dec 19, 2018
Merged
Merged
@jborean93
Copy link
Contributor Author

Backport PRs
stable-2.6 #50127
stable-2.7 #50128

@bcoca bcoca removed needs_triage Needs a first human triage before being processed. labels Jan 2, 2019
abadger pushed a commit that referenced this pull request Jan 7, 2019
@jborean93 @abadger
win_copy - fix remote dir copy when it contains an empty dir (#50126)
b6eebb0 
(cherry picked from commit 65ce1b7)
mattclay pushed a commit that referenced this pull request Jan 8, 2019
@jborean93 @mattclay
win_copy - fix remote dir copy when it contains an empty dir (#50126)
a574e0a 
(cherry picked from commit 65ce1b7)
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@jborean93 @kbreit
win_copy - fix remote dir copy when it contains an empty dir (ansible…
7434c35 
…#50126)
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

win_copy fails when copy an empty subfolder
3 participants
@jborean93 @ansibot @bcoca