Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add env command to ansible-test and run in CI. #50176

Merged
merged 17 commits into from
Dec 21, 2018
Merged

Add env command to ansible-test and run in CI. #50176

merged 17 commits into from
Dec 21, 2018

Conversation

mattclay
Copy link
Member

SUMMARY

Add env command to ansible-test and run in CI.

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

ansible-test

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Dec 20, 2018
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Dec 20, 2018
@ansibot
Copy link
Contributor

ansibot commented Dec 20, 2018

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/source_control/bitbucket_deploy_key.py:0:0: E319 RETURN.msg.type: not a valid value for dictionary value @ data['msg']['type']. Got 'string'

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Dec 20, 2018
@mattclay mattclay changed the title Add env command to ansible-test and run in CI. WIP - Add env command to ansible-test and run in CI. Dec 20, 2018
@ansibot ansibot added the WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. label Dec 20, 2018
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Dec 20, 2018
@ansibot ansibot removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Dec 20, 2018
@mattclay
Copy link
Member Author

I've also added skipping of docker pull for images when they are referenced by tag or digest. This should speed up tasks requiring Docker images. It will also improve reliability in situations where the containers are available locally but the remote repository is having issues (such as right now).

@mattclay mattclay changed the title WIP - Add env command to ansible-test and run in CI. Add env command to ansible-test and run in CI. Dec 21, 2018
@mattclay mattclay merged commit 01833b6 into ansible:devel Dec 21, 2018
@mattclay mattclay deleted the at-environment branch December 21, 2018 06:09
mattclay added a commit to mattclay/ansible that referenced this pull request Dec 22, 2018
@mattclay
[stable-2.7] Add env command to ansible-test and run in CI. (ansibl…
1cd313b 
…e#50176)

* Add `env` command to ansible-test and run in CI.
* Avoid unnecessary docker pull.
(cherry picked from commit 01833b6)

Co-authored-by: Matt Clay <matt@mystile.com>
mattclay added a commit to mattclay/ansible that referenced this pull request Dec 22, 2018
@mattclay
[stable-2.6] Add env command to ansible-test and run in CI. (ansibl…
f2bd2d0 
…e#50176)

* Add `env` command to ansible-test and run in CI.
* Avoid unnecessary docker pull.
(cherry picked from commit 01833b6)

Co-authored-by: Matt Clay <matt@mystile.com>
mattclay added a commit to mattclay/ansible that referenced this pull request Dec 22, 2018
@mattclay
[stable-2.5] Add env command to ansible-test and run in CI. (ansibl…
2434b13 
…e#50176)

* Add `env` command to ansible-test and run in CI.
* Avoid unnecessary docker pull.
(cherry picked from commit 01833b6)

Co-authored-by: Matt Clay <matt@mystile.com>
This was referenced Dec 22, 2018
Merged
Merged
Merged
mattclay added a commit that referenced this pull request Dec 22, 2018
@mattclay
[stable-2.6] Add env command to ansible-test and run in CI. (#50176)
6ba039c 
* Add `env` command to ansible-test and run in CI.
* Avoid unnecessary docker pull.
(cherry picked from commit 01833b6)

Co-authored-by: Matt Clay <matt@mystile.com>
mattclay added a commit that referenced this pull request Dec 22, 2018
@mattclay
[stable-2.5] Add env command to ansible-test and run in CI. (#50176)
6548b7a 
* Add `env` command to ansible-test and run in CI.
* Avoid unnecessary docker pull.
(cherry picked from commit 01833b6)

Co-authored-by: Matt Clay <matt@mystile.com>
mattclay added a commit that referenced this pull request Dec 22, 2018
@mattclay
[stable-2.7] Add env command to ansible-test and run in CI. (#50176)
60843a8 
* Add `env` command to ansible-test and run in CI.
* Avoid unnecessary docker pull.
(cherry picked from commit 01833b6)

Co-authored-by: Matt Clay <matt@mystile.com>
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@mattclay @kbreit
Add env command to ansible-test and run in CI. (ansible#50176)
a502136 
* Add `env` command to ansible-test and run in CI.
* Avoid unnecessary docker pull.
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jborean93 jborean93 jborean93 approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 feature This issue/PR relates to a feature request. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mattclay @ansibot @jborean93