Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker_image: improve tagging examples #50321

Merged
merged 1 commit into from
Dec 26, 2018
Merged

docker_image: improve tagging examples #50321

merged 1 commit into from
Dec 26, 2018

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Improves examples where images are tagged. Fixes #50310.

CC @cryptolukas

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

docker_image

@ansibot
Copy link
Contributor

ansibot commented Dec 26, 2018

cc @DBendit @akshay196 @chouseknecht @danihodovic @dariko @jwitko @kassiansun @softzilla @tbouvet
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 cloud community_review In order to be merged, this PR must follow the community review workflow. docker docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Dec 26, 2018
@felixfontein felixfontein mentioned this pull request Dec 26, 2018
Closed
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Dec 26, 2018
@gundalow gundalow merged commit 04e2a94 into ansible:devel Dec 26, 2018
@felixfontein felixfontein deleted the docker_image-tag-docs branch December 26, 2018 15:22
@felixfontein
Copy link
Contributor Author

@gundalow thanks for reviewing and merging!

@cryptolukas
Copy link

thanks both of you that you accept my recommendation :)

felixfontein added a commit to felixfontein/ansible that referenced this pull request Dec 26, 2018
@felixfontein
Improve tagging examples. (ansible#50321)
790829e 
(cherry picked from commit 04e2a94)
@felixfontein felixfontein mentioned this pull request Dec 26, 2018
Merged
@felixfontein
Copy link
Contributor Author

@cryptolukas well, thanks for your recommendation :) There's still a lot to improve in the docker_image documentation, so if you have some more ideas, feel free to mention them ;-)

@cryptolukas
Copy link

I come back to you when have one.

At the moment I prepare a CD from scratch with Ansible and Jenkins, with Docker. A lot of work still before me. :)

abadger pushed a commit that referenced this pull request Jan 7, 2019
@felixfontein @abadger
Improve tagging examples. (#50321)
a5bf418 
(cherry picked from commit 04e2a94)
kbreit pushed a commit to kbreit/ansible that referenced this pull request Jan 11, 2019
@felixfontein @kbreit
Improve tagging examples. (ansible#50321)
a8c69fb
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 cloud community_review In order to be merged, this PR must follow the community review workflow. docker docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker (Re)Tag local images
4 participants
@felixfontein @ansibot @cryptolukas @gundalow