Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regex_escape: support POSIX basic regex #50327

Merged
merged 3 commits into from
Mar 7, 2019

Conversation

jamescassell
Copy link
Contributor

SUMMARY
regex_escape - added re_type option to enable escaping POSIX BRE chars

This distinction is necessary because escaping non-special chars such as
'(' or '{' turns them into special chars, the opposite of what is intended
by using regex_escape on strings being passed as a Basic Regular
Expression.
ISSUE TYPE
  • Docs Pull Request
  • Feature Pull Request
COMPONENT NAME

regex_escape

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Dec 26, 2018

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Dec 26, 2018
@jamescassell jamescassell reopened this Dec 26, 2018
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Dec 26, 2018
@jamescassell
Copy link
Contributor Author

Not sure why the test failed:

09:56 TASK [setup_mysql_db : install mysqldb_test rpm dependencies] ******************
10:10 changed: [testhost] => (item=['mariadb-server', 'python3-PyMySQL', 'bzip2']) => {"changed": true, "item": ["mariadb-server", "python3-PyMySQL", "bzip2"], "msg": "", "rc": 0, "results": ["Installed: mariadb-server", "Installed: python3-PyMySQL", "Installed: bzip2"]}

then:

 failure: The PyMySQL (Python 2.7 and Python 3.X) or MySQL-python (Python 2.X) module is required.

{
"changed": false,
"msg": "The PyMySQL (Python 2.7 and Python 3.X) or MySQL-python (Python 2.X) module is required."
}

Seems unrelated to my changes.

@jamescassell jamescassell reopened this Dec 29, 2018
@jamescassell jamescassell reopened this Jan 1, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 2, 2019
@samdoran samdoran self-assigned this Jan 8, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jan 8, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 8, 2019
@jamescassell
Copy link
Contributor Author

Let me know if you'd like me to close / reopen to try to get the test to pass

@jamescassell jamescassell reopened this Jan 9, 2019
@jamescassell jamescassell reopened this Jan 9, 2019
@jamescassell
Copy link
Contributor Author

bot_status

@ansibot
Copy link
Contributor

ansibot commented Jan 10, 2019

Components

changelogs/fragments/regex-escape-basic.yaml
support: community
maintainers:

docs/docsite/rst/user_guide/playbooks_filters.rst
support: core
maintainers: acozine

lib/ansible/plugins/filter/core.py
support: core
maintainers:

Metadata

waiting_on: ansible
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 0
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainer or core team member): []
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 10, 2019
@acozine
Copy link
Contributor

acozine commented Jan 10, 2019

Can you move the version_added note up above the line that begins: To escape special characters within a POSIX basic regex? The way it is now, when I generate the page, it looks like that's the version_added for the Kubernetes filter.

Otherwise the documentation part of this PR looks good. Thanks @jamescassell.

@jamescassell
Copy link
Contributor Author

@acozine, I'm happy to make that change, but it seems as if other uses of version_added appear at the end of the section describing the functionality. Likely changes are required throughout the page to make it consistent.

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jan 21, 2019
@jamescassell jamescassell reopened this Mar 7, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 7, 2019
@samdoran samdoran merged commit e55e8fe into ansible:devel Mar 7, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants