Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert: allow list of strings in msg or failed_msg #50531

Merged
merged 1 commit into from
Mar 5, 2019
Merged

assert: allow list of strings in msg or failed_msg #50531

merged 1 commit into from
Mar 5, 2019

Conversation

Akasurde
Copy link
Member

@Akasurde Akasurde commented Jan 4, 2019 •
edited

SUMMARY

Added check for assert module for msg and failed_msg as a list or string types.

Fixes: #48547

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

changelogs/fragments/48547-assert-incorrect_msg_type.yml
lib/ansible/plugins/action/assert.py

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jan 4, 2019
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Jan 8, 2019
bcoca
bcoca requested changes Jan 8, 2019
View reviewed changes
Copy link
Member

@bcoca bcoca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was my bad and i should have caught in review of the pr that created the problem.

the solution would be to allow for string or list of strings, not deprecate the latter

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 8, 2019
@Akasurde Akasurde changed the title assert: change AnsibleError to warning assert: allow list of strings in msg or failed_msg Jan 9, 2019
@Akasurde
Copy link
Member Author

Akasurde commented Jan 9, 2019

@bcoca Could you please take another look into this ? Thanks in advance.

@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Jan 17, 2019
@Akasurde
assert: allow list of strings in msg or failed_msg
ae140b3 
Added check for assert module for msg and failed_msg as a list or string types.

Fixes: ansible#48547

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot ansibot removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Feb 27, 2019
@Akasurde Akasurde requested a review from bcoca March 4, 2019 15:41
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 4, 2019
@Akasurde Akasurde merged commit d39f35c into ansible:devel Mar 5, 2019
@Akasurde Akasurde deleted the i48547 branch March 5, 2019 05:42
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bcoca bcoca bcoca approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

regression: assert msg no longer accepts list
4 participants
@Akasurde @bcoca @samdoran @ansibot