Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more return values to *_config modules #50702

Merged
merged 12 commits into from
Jan 28, 2019
Merged

Conversation

NilashishC
Copy link
Contributor

@NilashishC NilashishC commented Jan 9, 2019

Signed-off-by: NilashishC nilashishchakraborty8@gmail.com

SUMMARY
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ios_config
nxos_config
iosxr_config
vyos_config
eos_config
junos_config

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team. labels Jan 9, 2019
@ansibot
Copy link
Contributor

ansibot commented Jan 9, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 6 errors:

lib/ansible/modules/network/eos/eos_config.py:0:0: E319 RETURN.date.sample: not a valid value for dictionary value @ data['date']['sample']. Got datetime.date(2016, 7, 16)
lib/ansible/modules/network/ios/ios_config.py:0:0: E319 RETURN.date.sample: not a valid value for dictionary value @ data['date']['sample']. Got datetime.date(2016, 7, 16)
lib/ansible/modules/network/iosxr/iosxr_config.py:0:0: E319 RETURN.date.sample: not a valid value for dictionary value @ data['date']['sample']. Got datetime.date(2016, 7, 16)
lib/ansible/modules/network/junos/junos_config.py:0:0: E319 RETURN.date.sample: not a valid value for dictionary value @ data['date']['sample']. Got datetime.date(2016, 7, 16)
lib/ansible/modules/network/nxos/nxos_config.py:0:0: E319 RETURN.date.sample: not a valid value for dictionary value @ data['date']['sample']. Got datetime.date(2016, 7, 16)
lib/ansible/modules/network/vyos/vyos_config.py:0:0: E319 RETURN.date.sample: not a valid value for dictionary value @ data['date']['sample']. Got datetime.date(2016, 7, 16)

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jan 9, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 10, 2019
@NilashishC
Copy link
Contributor Author

As discussed with @ganeshrn, parking this PR till #50801 gets merged.

@ikhan2010
Copy link

@NilashishC can you please check why checks are failing?

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@ansibot ansibot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jan 25, 2019
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC
Copy link
Contributor Author

Looks like CI infra failures again:

{
"changed": false,
"msg": "Failed to download packages: Status code: 503 for https://mirrors.fedoraproject.org/metalink?repo=fedora-29&arch=x86_64",
"results": []
}

Will re-kick the tests after a while to see if it passes then.

@NilashishC NilashishC closed this Jan 28, 2019
@NilashishC NilashishC reopened this Jan 28, 2019
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 28, 2019
@NilashishC NilashishC merged commit 92b0cd8 into ansible:devel Jan 28, 2019
@NilashishC NilashishC deleted the backup_rv branch January 28, 2019 15:20
@dagwieers dagwieers added the cisco Cisco technologies label Feb 22, 2019
@dagwieers dagwieers added the ios Cisco IOS community label Mar 4, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. ios Cisco IOS community module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provide filename output from return values for *os_config modules and cli_config
7 participants