-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more return values to *_config modules #50702
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.8
This issue/PR affects Ansible v2.8
core_review
In order to be merged, this PR must follow the core review workflow.
feature
This issue/PR relates to a feature request.
module
This issue/PR relates to a module.
needs_triage
Needs a first human triage before being processed.
networking
Network category
nxos
Cisco NXOS community
support:network
This issue/PR relates to code supported by the Ansible Network Team.
labels
Jan 9, 2019
justjais
approved these changes
Jan 9, 2019
The test
|
ansibot
added
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
core_review
In order to be merged, this PR must follow the core review workflow.
needs_ci
This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI.
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
and removed
core_review
In order to be merged, this PR must follow the core review workflow.
needs_triage
Needs a first human triage before being processed.
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
needs_ci
This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI.
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
labels
Jan 9, 2019
trishnaguha
approved these changes
Jan 9, 2019
ganeshrn
reviewed
Jan 9, 2019
ansibot
added
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
and removed
core_review
In order to be merged, this PR must follow the core review workflow.
labels
Jan 10, 2019
ganeshrn
reviewed
Jan 11, 2019
@NilashishC can you please check why checks are failing? |
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
ansibot
removed
needs_rebase
https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
stale_ci
This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
labels
Jan 25, 2019
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
Looks like CI infra failures again:
Will re-kick the tests after a while to see if it passes then. |
ganeshrn
reviewed
Jan 28, 2019
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
ganeshrn
approved these changes
Jan 28, 2019
ansibot
added
core_review
In order to be merged, this PR must follow the core review workflow.
and removed
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
labels
Jan 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.8
This issue/PR affects Ansible v2.8
cisco
Cisco technologies
core_review
In order to be merged, this PR must follow the core review workflow.
feature
This issue/PR relates to a feature request.
ios
Cisco IOS community
module
This issue/PR relates to a module.
networking
Network category
nxos
Cisco NXOS community
support:network
This issue/PR relates to code supported by the Ansible Network Team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: NilashishC nilashishchakraborty8@gmail.com
SUMMARY
ISSUE TYPE
COMPONENT NAME
ios_config
nxos_config
iosxr_config
vyos_config
eos_config
junos_config