Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new module - junos_ping #50711

Merged
merged 13 commits into from
Jan 29, 2019
Merged

Add new module - junos_ping #50711

merged 13 commits into from
Jan 29, 2019

Conversation

NilashishC
Copy link
Contributor

@NilashishC NilashishC commented Jan 9, 2019 •
edited

SUMMARY
ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

junos_ping.py

@NilashishC
WIP junos_ping
ee7a878 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC
Added junos_ping module
c4d8dc9 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC
Minor changes
7fbb023 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC
Minor changes - 2
4b058a2 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC NilashishC added support:network This issue/PR relates to code supported by the Ansible Network Team. new_module This PR includes a new module. module This issue/PR relates to a module. labels Jan 9, 2019
@ansibot
Copy link
Contributor

ansibot commented Jan 9, 2019

cc @Qalthos @ganeshrn @gdpak @justjais @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. networking Network category new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. and removed support:network This issue/PR relates to code supported by the Ansible Network Team. labels Jan 9, 2019
@NilashishC
Fix CI
6c4a55e 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC NilashishC added support:network This issue/PR relates to code supported by the Ansible Network Team. and removed support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jan 9, 2019
@ansibot ansibot added support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed support:network This issue/PR relates to code supported by the Ansible Network Team. labels Jan 9, 2019
@Qalthos Qalthos changed the title Add new module - junos_ping [WIP] Add new module - junos_ping Jan 9, 2019
@ansibot ansibot added the WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. label Jan 9, 2019
@NilashishC
Initial tests
aa53a42 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC
WIP tests
f612663 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@ansibot
Copy link
Contributor

ansibot commented Jan 11, 2019

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

test/units/modules/network/junos/test_junos_ping.py:27:1: E302 expected 2 blank lines, found 1
test/units/modules/network/junos/test_junos_ping.py:38:5: E303 too many blank lines (2)
test/units/modules/network/junos/test_junos_ping.py:43:5: E303 too many blank lines (2)

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Jan 11, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jan 19, 2019
@NilashishC
Fix spaces
40fd6f0 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Jan 28, 2019
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jan 28, 2019
@NilashishC
Fixed unit tests
ce4e5fa 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC
Removed unused print statements
a3aa1ad 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC
Removed unused print statements
9f9b6c0 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC NilashishC changed the title [WIP] Add new module - junos_ping Add new module - junos_ping Jan 28, 2019
@NilashishC NilashishC removed the WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. label Jan 28, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 28, 2019
@NilashishC
Update license template
7b182b8 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 28, 2019
@NilashishC
Fixed Review Comments
b73259b 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC
Copy link
Contributor Author

@ganeshrn made the changes.

@NilashishC NilashishC merged commit 77303d7 into ansible:devel Jan 29, 2019
@NilashishC NilashishC deleted the junos_ping branch January 29, 2019 10:06
@NilashishC NilashishC mentioned this pull request Jan 29, 2019
Closed
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ganeshrn ganeshrn ganeshrn approved these changes

@trishnaguha trishnaguha trishnaguha approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NilashishC @ansibot @ganeshrn @trishnaguha