Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgresql_ext: cascade extension creating/deleting #50717

Merged
merged 2 commits into from
Feb 2, 2019
Merged

postgresql_ext: cascade extension creating/deleting #50717

merged 2 commits into from
Feb 2, 2019

Conversation

kostiantyn-nemchenko
Copy link
Contributor

SUMMARY

Currently, without CASCADE clause, if an extension has an unfulfilled dependency on another extension,
CREATE EXTENSION errors out with "required extension ... is not installed" or, if an extension is a dependency for another extension, DROP EXTENSION fails with "cannot drop extension ... because other objects depend on it".
This PR adds support for creating/deleting extensions with their dependencies.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

postgresql_ext

ADDITIONAL INFORMATION

Task example:

- postgresql_ext:
    name: earthdistance
    db: template1
    cascade: true

@ansibot
Copy link
Contributor

ansibot commented Jan 9, 2019

cc @andytom @dschep @matburt
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. labels Jan 9, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jan 9, 2019
@andytom
Copy link
Contributor

andytom commented Jan 10, 2019

shipit

@andytom
Copy link
Contributor

andytom commented Jan 11, 2019

bot_status

1 similar comment
@kostiantyn-nemchenko
Copy link
Contributor Author

bot_status

@ansibot
Copy link
Contributor

ansibot commented Jan 12, 2019

Components

lib/ansible/modules/database/postgresql/postgresql_ext.py
support: community
maintainers: andytom dschep matburt

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 1
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): andytom
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jan 20, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jan 23, 2019
@Andersson007
Copy link
Contributor

Andersson007 commented Jan 23, 2019 •
edited

Also add information to 'notes' section that 'cascade' parameter is supported from version 9.6 of PgSQL.

I've tried it, it works correctly (absent, present).

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html postgresql PostgreSQL community labels Jan 31, 2019
@kostiantyn-nemchenko
Copy link
Contributor Author

kostiantyn-nemchenko commented Jan 31, 2019 •
edited

Addressed @Andersson007's feedback.

@ansibot
Copy link
Contributor

ansibot commented Jan 31, 2019

@kostiantyn-nemchenko this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot added merge_commit This PR contains at least one merge commit. Please resolve! and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jan 31, 2019
@ansibot ansibot removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Jan 31, 2019
@kostiantyn-nemchenko
Copy link
Contributor Author

ready_for_review

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 31, 2019
@Andersson007
Copy link
Contributor

Andersson007 commented Feb 1, 2019 •
edited

I tested it again, just in case. Can be really useful, thank you!

@Andersson007
Copy link
Contributor

shipit

@kostiantyn-nemchenko
Copy link
Contributor Author

bot_status

@ansibot
Copy link
Contributor

ansibot commented Feb 2, 2019

cc @amenonsen @dagwieers @jbscalia @nerzhul
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Feb 2, 2019

Components

lib/ansible/modules/database/postgresql/postgresql_ext.py
support: community
maintainers: Andersson007 amenonsen andytom dagwieers dschep kostiantyn-nemchenko matburt nerzhul

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 2
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): Andersson007 kostiantyn-nemchenko
shipit_actors_other: []
automerge: automerge tests passed

click here for bot help

@ansibot ansibot added automerge This PR was automatically merged by ansibot. owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core test This PR relates to tests. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Feb 2, 2019
@ansibot ansibot merged commit e812875 into ansible:devel Feb 2, 2019
@dagwieers
Copy link
Contributor

Nice to see this work ;-)

@dagwieers dagwieers added the database Database category label Feb 13, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andytom andytom andytom left review comments

@Andersson007 Andersson007 Andersson007 approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 automerge This PR was automatically merged by ansibot. database Database category feature This issue/PR relates to a feature request. module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. owner_pr This PR is made by the module's maintainer. postgresql PostgreSQL community shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kostiantyn-nemchenko @ansibot @andytom @Andersson007 @dagwieers