Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Options for Autosupport #50773

Merged
merged 7 commits into from
Jan 23, 2019
Merged

New Options for Autosupport #50773

merged 7 commits into from
Jan 23, 2019

Conversation

carchi8py
Copy link
Contributor

SUMMARY

Adds new option for Autosupport

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • na_ontap_autosupport
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Jan 10, 2019

cc @amit0701 @hulquest @lmprice @lonico @ndswartz @schmots1
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. netapp storage support:certified This issue/PR relates to certified code. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jan 10, 2019
@ansibot
Copy link
Contributor

ansibot commented Jan 10, 2019

The test ansible-test sanity --test no-underscore-variable [explain] failed with 1 error:

lib/ansible/modules/storage/netapp/na_ontap_autosupport.py:194:21: use `dummy` instead of `_` for a variable name

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 10, 2019
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Jan 14, 2019
@carchi8py carchi8py mentioned this pull request Jan 14, 2019
Merged
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 14, 2019
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Jan 15, 2019
@carchi8py carchi8py mentioned this pull request Jan 22, 2019
Merged
thedoubl3j
thedoubl3j reviewed Jan 23, 2019
View reviewed changes
Copy link
Member

@thedoubl3j thedoubl3j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @gundalow if we could prioritize this PR as some of the other PRs need somethings in to run properly.

@gundalow gundalow merged commit 890f4eb into ansible:devel Jan 23, 2019
@gundalow
Copy link
Contributor

@carchi8py Thank you for the PR
@thedoubl3j Thanks for the review.

This is a feature PR, so only merging into devel

@ansible ansible locked and limited conversation to collaborators Jul 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thedoubl3j thedoubl3j thedoubl3j left review comments

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. netapp storage support:certified This issue/PR relates to certified code. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@carchi8py @ansibot @gundalow @thedoubl3j @bcoca