Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing parameters in get_config vyos #50855

Merged
merged 1 commit into from
Jan 14, 2019
Merged

Add missing parameters in get_config vyos #50855

merged 1 commit into from
Jan 14, 2019

Conversation

trishnaguha
Copy link
Member

@trishnaguha trishnaguha commented Jan 14, 2019 •
edited

Signed-off-by: Trishna Guha trishnaguha17@gmail.com

SUMMARY

Add missing parameters in get_config vyos
The parameters are present in cliconf https://github.com/ansible/ansible/blob/devel/lib/ansible/plugins/cliconf/vyos.py#L57

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

module_utils/network/vyos/vyos.py

@trishnaguha
Add missing parameters in get_config vyos
bca4225 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@ansibot
Copy link
Contributor

ansibot commented Jan 14, 2019

cc @NilashishC @Qalthos @ganeshrn @gdpak @justjais @rcarrillocruz
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. networking Network category small_patch support:network This issue/PR relates to code supported by the Ansible Network Team. labels Jan 14, 2019
@trishnaguha trishnaguha removed the needs_triage Needs a first human triage before being processed. label Jan 14, 2019
@trishnaguha trishnaguha added this to Needs Triage in Networking via automation Jan 14, 2019
@trishnaguha trishnaguha merged commit fc0f20a into ansible:devel Jan 14, 2019
Networking automation moved this from Needs Triage to Done Jan 14, 2019
@trishnaguha trishnaguha deleted the vyos_get_config_module_utils branch January 14, 2019 09:44
knumskull pushed a commit to knumskull/ansible that referenced this pull request Jan 21, 2019
@trishnaguha @knumskull
Add missing parameters in get_config vyos (ansible#50855)
1c206ea 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
trishnaguha added a commit to trishnaguha/ansible that referenced this pull request Apr 1, 2019
@trishnaguha
Add missing parameters in get_config vyos (ansible#50855)
b4c316b 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit fc0f20a)
abadger pushed a commit that referenced this pull request Apr 4, 2019
@trishnaguha @abadger
Add missing parameters in get_config vyos (#50855)
5d73a98 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit fc0f20a)
@ansible ansible locked and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ganeshrn ganeshrn ganeshrn approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. networking Network category small_patch support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
No open projects
Networking
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@trishnaguha @ansibot @ganeshrn