Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy module - Clarify use of variables in content parameter #50940

Merged
merged 1 commit into from
Jan 29, 2019
Merged

Copy module - Clarify use of variables in content parameter #50940

merged 1 commit into from
Jan 29, 2019

Conversation

samdoran
Copy link
Contributor

@samdoran samdoran commented Jan 15, 2019 •
edited

SUMMARY

Further clarify that variables should not be used in the content field.
Change I() to C() for inline code formatting.

Fixes #50580

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

lib/ansible/modules/files/copy.py

ADDITIONAL INFORMATION

Related to #34595

Further explanation of why this should avoided.

@ansibot
Copy link
Contributor

ansibot commented Jan 15, 2019

cc @ptux
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jan 15, 2019
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Jan 15, 2019
@ptux
Copy link
Contributor

ptux commented Jan 16, 2019

@samdoran

Let me ask a primitive question.
What's the meaning and difference of I() and C()?

@samdoran
Copy link
Contributor Author

@ptux I() formats the text in italic, C() formats the text as in-line code.

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 24, 2019
@samdoran samdoran force-pushed the issue/50580-copy-content-docs branch from d119b2d to 381d94b Compare January 29, 2019 17:20
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jan 29, 2019
@samccann samccann merged commit b956184 into ansible:devel Jan 29, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
@samdoran samdoran deleted the issue/50580-copy-content-docs branch September 11, 2023 15:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samccann samccann samccann approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ansible misrender files from multiline variable if it's json formated with literal \n inside.
5 participants
@samdoran @ansibot @ptux @samccann @bcoca