User - Create parent directories if they do not exist in the specified home path #51043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.8
samdoran
force-pushed
the
issue/41393-user-home-with-parents
branch
from
e3a4dfa
to
95b921a
Compare
ansibot
added
core_review
bcoca
removed
the
needs_triage
ansibot
added
the
stale_ci
ansibot
removed
the
stale_ci
samdoran
force-pushed
the
issue/41393-user-home-with-parents
branch
from
95b921a
to
bcfd5c2
Compare
ansibot
added
the
stale_ci
|
bot_status |
Componentschangelogs/fragments/user-home-dir-with-no-parents.yaml lib/ansible/modules/system/user.py test/integration/targets/user/tasks/main.yml test/integration/targets/user/vars/main.yml Metadatawaiting_on: ansible |
ansibot
removed
the
stale_ci
ansibot
added
the
stale_ci
samdoran
force-pushed
the
issue/41393-user-home-with-parents
branch
from
bcfd5c2
to
5c906de
Compare
ansibot
removed
the
stale_ci
ansibot
added
the
stale_ci
The useradd command line tool does not create parent directories. Check if the specified home path has parents that do not exist. If so, create them prior to running useradd, then set the proper permission on the created directory. Add tests Signed-off-by: Sam Doran <sdoran@redhat.com>
Signed-off-by: Sam Doran <sdoran@redhat.com>
samdoran
force-pushed
the
issue/41393-user-home-with-parents
branch
from
5c906de
to
bb53911
Compare
ansibot
removed
the
stale_ci
ansibot
added
the
stale_ci
|
rebuild_merge |
ansibot
added
shipit
samdoran
added a commit
to samdoran/ansible
that referenced
this pull request
Jul 18, 2019
… the specified home path (ansible#51043) * Create a user home directory if it has parents that do not exist The useradd command line tool does not create parent directories. Check if the specified home path has parents that do not exist. If so, create them prior to running useradd, then set the proper permission on the created directory. Add tests Signed-off-by: Sam Doran <sdoran@redhat.com> * Use dict for default user group in tests Signed-off-by: Sam Doran <sdoran@redhat.com> * Fix tests Signed-off-by: Sam Doran <sdoran@redhat.com> (cherry picked from commit d2edf1d) Co-authored-by: Sam Doran <sdoran@redhat.com>
samdoran
pushed a commit
to samdoran/ansible
that referenced
this pull request
Aug 12, 2019
Fixes ansible#60307. This bug was introduced in commit d2edf1d ("User - Create parent directories if they do not exist in the specified home path (ansible#51043)") and did not make it into any releases. (cherry picked from commit c71622b)
StephenSorriaux
pushed a commit
to StephenSorriaux/ansible
that referenced
this pull request
Aug 12, 2019
Fixes ansible#60307. This bug was introduced in commit d2edf1d ("User - Create parent directories if they do not exist in the specified home path (ansible#51043)") and did not make it into any releases.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #41393
The
useraddcommand line tool does not create parent directories. The PR checks if the specified home path has parents that do not exist. If so, create them prior to runninguseradd, then set the proper permission on the created directory.This would fail on the first run because the code it was hitting only checked for missing home directories when the user account existed. The first run code was relying on
useraddto create the home directory if it didn't exist, which it usually does. But when parent directories do not exist,useraddsimply fails to create the home directory though it does create the account on the system.Also add integration tests.
Signed-off-by: Sam Doran sdoran@redhat.com
ISSUE TYPE
COMPONENT NAME
user.py