Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add inject_ovf_env functionality for vmware_deploy_ovf #51074

Merged
merged 6 commits into from
Jan 28, 2019
Merged

Add inject_ovf_env functionality for vmware_deploy_ovf #51074

merged 6 commits into from
Jan 28, 2019

Conversation

sivel
Copy link
Member

@sivel sivel commented Jan 18, 2019

SUMMARY

Add inject_ovf_env functionality. Fixes #50299

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/vmware/vmware_deploy_ovf.py

ADDITIONAL INFORMATION

@sivel sivel requested a review from Akasurde January 18, 2019 17:06
@sivel sivel mentioned this pull request Jan 18, 2019
Closed
@ansibot
Copy link
Contributor

ansibot commented Jan 18, 2019

cc @Akasurde @ckotte @dav1x @warthog9
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 cloud community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community labels Jan 18, 2019
@ansibot
Copy link
Contributor

ansibot commented Jan 18, 2019

The test ansible-test sanity --test changelog [explain] failed with 1 error:

changelogs/fragments/vmware-deploy-ovf-injext.yml:0:0: yaml parsing error

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_deploy_ovf.py:0:0: E325 argument_spec for "inject_ovf_env" defines type="bool" but documentation does not

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

changelogs/fragments/vmware-deploy-ovf-injext.yml:2:3: error syntax error: found character '`' that cannot start any token

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jan 18, 2019
@Akasurde
Minor changes
dc79ba9 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 21, 2019
Akasurde
Akasurde approved these changes Jan 21, 2019
View reviewed changes
Copy link
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Jan 21, 2019
@sivel
Copy link
Member Author

sivel commented Jan 28, 2019

I'm going to go ahead and merge this. 2 users have validated it seems to be working as expected.

@sivel sivel merged commit 134b779 into ansible:devel Jan 28, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Akasurde Akasurde Akasurde approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 cloud feature This issue/PR relates to a feature request. module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vmware_deploy_ovf: Properties not being passed to post configuration
3 participants
@sivel @ansibot @Akasurde