Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fix from "installed" to "present" #51079

Merged
merged 4 commits into from Mar 22, 2019
Merged

Small fix from "installed" to "present" #51079

merged 4 commits into from Mar 22, 2019

Conversation

AgileinOrange
Copy link
Contributor

Testing a small commit, but it is a real change.

SUMMARY
ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

N/A

ADDITIONAL INFORMATION

First, pull request, hope it works...

@ansibot
Copy link
Contributor

ansibot commented Jan 18, 2019

cc @acozine
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jan 18, 2019
@ansibot
Copy link
Contributor

ansibot commented Jan 18, 2019

cc @alcamie101
click here for bot help

@ansibot ansibot added module This issue/PR relates to a module. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. net_tools Net-tools category stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. and removed core_review In order to be merged, this PR must follow the core review workflow. small_patch needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jan 18, 2019
@ansibot
Copy link
Contributor

ansibot commented Jan 18, 2019

cc @caphrim007
click here for bot help

@ansibot ansibot added f5 networking Network category support:certified This issue/PR relates to certified code. labels Jan 18, 2019
@ansibot
Copy link
Contributor

ansibot commented Jan 18, 2019

cc @melodous
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jan 26, 2019

cc @bcoca @dagwieers
click here for bot help

@ansibot ansibot added hpux HP-UX community stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jan 26, 2019
@caphrim007
Copy link
Contributor

@wojtek0806 please review this with the f5-networks repo code and advise on changes.

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jan 26, 2019
@wojtek0806
Copy link
Contributor

@HerontheCLI I would like the changes done to the F5 module reverted back as they are not inappropriate to the module function. Present and Installed states have two distinct functionalities for that module and that change would break stable interface.

@ansibot
Copy link
Contributor

ansibot commented Jan 27, 2019

cc @davx8342
click here for bot help

@dagwieers
Copy link
Contributor

For swdepot, this is already taken care of in #51106

@ansibot ansibot added the packaging Packaging category label Feb 14, 2019
gundalow
gundalow previously requested changes Feb 14, 2019
View reviewed changes
Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @HerontheCLI Thanks for this PR

Could you please revert the changes to
lib/ansible/modules/network/f5
lib/ansible/modules/packaging/os/swdepot.py

Taz Brown added 3 commits March 21, 2019 18:44
@ansibot ansibot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:certified This issue/PR relates to certified code. labels Mar 21, 2019
@acozine
Copy link
Contributor

acozine commented Mar 22, 2019

Looks like that Windows module actually does not use state: present - see https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/windows/win_updates.py and https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/windows/win_updates.ps1#L16.

@acozine acozine dismissed gundalow’s stale review March 22, 2019 00:48

Changes to F5 and swdepot modules reverted, as requested.

@ansibot ansibot removed the support:core This issue/PR relates to code supported by the Ansible Engineering Team. label Mar 22, 2019
@acozine acozine merged commit 688016f into ansible:devel Mar 22, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow left review comments

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. f5 hpux HP-UX community module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. net_tools Net-tools category networking Network category new_contributor This PR is the first contribution by a new community member. packaging Packaging category support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@AgileinOrange @ansibot @caphrim007 @wojtek0806 @dagwieers @acozine @gundalow