Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ansible.Basic - make choices validate case insensitive #51203

Merged
merged 2 commits into from
Jan 28, 2019
Merged

Ansible.Basic - make choices validate case insensitive #51203

merged 2 commits into from
Jan 28, 2019

Conversation

jborean93
Copy link
Contributor

SUMMARY

Currently the choice validation for Ansible.Basic in Windows is case sensitive which is a break from the choice validation in the existing PowerShell util. This change makes things case insensitive for backwards compatibility but also adds a warning saying this will change sometime in the future. Also slightly refactors the options context message to a shared implementation.

Fixes #51063

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

Ansible.Basic.cs

@jborean93 jborean93 mentioned this pull request Jan 23, 2019
Closed
@ansibot
Copy link
Contributor

ansibot commented Jan 23, 2019

cc @nitzmahone
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 23, 2019
@ansibot
Copy link
Contributor

ansibot commented Jan 23, 2019

cc @dagwieers @jhawkesworth
click here for bot help

@varunchopra
Copy link
Contributor

LGTM

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 23, 2019
@jborean93 jborean93 merged commit a259b81 into ansible:devel Jan 28, 2019
@jborean93 jborean93 deleted the win-basic-choices branch January 28, 2019 19:42
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Jan 29, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ansible.Basic: "choices" are case-sensitive
4 participants
@jborean93 @ansibot @varunchopra @sivel