Ignore AttributeError when trying to import p paramiko #51243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.8
nitzmahone
approved these changes
Jan 29, 2019
ansibot
removed
the
needs_triage
nitzmahone
requested changes
Jan 29, 2019
There was a problem hiding this comment.
While this hides the warning for people who aren't using paramiko, it also makes it harder to see the real problem for someone who is using paramiko if python-gssapi is installed (or any other failure happens during import). Would be better to store + re-raise the error in connect or some other method where it's clear that someone's actually trying to use the connection.
nitzmahone
approved these changes
Jan 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When the newer gssapi library is installed, paramiko will fail to import and will raise an AttributeError. It is expecting the older and deprecated gssapi library but there is a namespace collision here. There's a PR to support the newer library in paramiko paramiko/paramiko#1311 but this doesn't seem to be going anywhere fast.
ISSUE TYPE
COMPONENT NAME
connection/netconf
connection/paramiko_ssh