Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer to use gmake (if available) on non linux OS #51294

Merged
merged 2 commits into from Jan 26, 2019
Merged

Prefer to use gmake (if available) on non linux OS #51294

merged 2 commits into from Jan 26, 2019

Conversation

mator
Copy link
Contributor

@mator mator commented Jan 24, 2019

SUMMARY

Prefer to use gmake (GNU make , if available) on non linux OS.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

module/system/make

ADDITIONAL INFORMATION

Fixes #26187

@ansibot
Copy link
Contributor

ansibot commented Jan 24, 2019

cc @LinusU
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Jan 24, 2019
resmo
resmo approved these changes Jan 26, 2019
View reviewed changes
Copy link
Contributor

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jan 26, 2019
@dagwieers dagwieers added aix AIX community solaris Solaris community hpux HP-UX community bsd BSD community labels Jan 26, 2019
@dagwieers dagwieers merged commit 88dee04 into ansible:devel Jan 26, 2019
@dagwieers
Copy link
Contributor

@mator I noticed you are working on your own devel branch, but that's probably not the best way forward. It is better to create a local branch where you commit your own fixes/features to and then push that branch and make a PR from that branch.

@dagwieers
Copy link
Contributor

Nevertheless thanks for this fix !

@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@resmo resmo resmo approved these changes

@dagwieers dagwieers dagwieers approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 aix AIX community bsd BSD community community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. hpux HP-UX community module This issue/PR relates to a module. small_patch solaris Solaris community support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prefer GNU make if available
4 participants
@mator @ansibot @dagwieers @resmo