Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add info about relative paths to config page #51351

Merged
merged 4 commits into from Feb 21, 2019
Merged

add info about relative paths to config page #51351

merged 4 commits into from Feb 21, 2019

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Jan 25, 2019

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

config

@ansibot
Copy link
Contributor

ansibot commented Jan 25, 2019

cc @acozine
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jan 25, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jan 27, 2019
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 28, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. small_patch labels Jan 30, 2019
Akasurde
Akasurde approved these changes Jan 31, 2019
View reviewed changes
Copy link
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 31, 2019
@acozine
Copy link
Contributor

acozine commented Feb 13, 2019

I'm surprised this is passing Shippable - don't we have a test for line length?

@acozine
Copy link
Contributor

acozine commented Feb 13, 2019

@bcoca what's the motivation for adding this to the docs? I've broken up the line and done some tidying, but I'd like to know more before merging.

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed shipit This PR is ready to be merged by Core labels Feb 13, 2019
@bcoca
Copy link
Member Author

bcoca commented Feb 18, 2019

@acozine to document how setting = ./mypath works from configuration files, it is not specified anywhere currently.

@acozine acozine merged commit 2c63f45 into ansible:devel Feb 21, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Akasurde Akasurde Akasurde approved these changes

Assignees

@acozine acozine

Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bcoca @ansibot @acozine @Akasurde