Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to enter admin configuration mode in iosxr_user #51430

Merged
merged 3 commits into from
Jan 30, 2019
Merged

Add option to enter admin configuration mode in iosxr_user #51430

merged 3 commits into from
Jan 30, 2019

Conversation

NilashishC
Copy link
Contributor

Signed-off-by: NilashishC nilashishchakraborty8@gmail.com

SUMMARY
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

iosxr_user.py

@NilashishC
Add admin mode to iosxr_user
018ffa5 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC NilashishC added the support:network This issue/PR relates to code supported by the Ansible Network Team. label Jan 29, 2019
@ansibot
Copy link
Contributor

ansibot commented Jan 29, 2019

cc @Qalthos @ganeshrn @gdpak @justjais @kedarX @rcarrillocruz @sebasdoes @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Jan 29, 2019
@NilashishC
Update docs for admin option
620f311 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
justjais
justjais reviewed Jan 30, 2019
View reviewed changes
lib/ansible/modules/network/iosxr/iosxr_user.py
- Applicable only when using network_cli transport
type: bool
default: false
version_added: "2.8"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NilashishC can you give a related example under examples, so that user may get to know how to use the respective admin config mode.

justjais
justjais reviewed Jan 30, 2019
View reviewed changes
Copy link
Contributor

@justjais justjais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check the comment

@NilashishC
Fix review comment
8beaa92 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
@NilashishC NilashishC merged commit 2f0c666 into ansible:devel Jan 30, 2019
@NilashishC NilashishC deleted the admin_mode branch January 30, 2019 10:07
@NilashishC NilashishC mentioned this pull request Jan 30, 2019
Closed
@Qalthos Qalthos mentioned this pull request Jan 30, 2019
Closed
@dagwieers dagwieers added iosxr Cisco IOSXR community cisco Cisco technologies labels Feb 22, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trishnaguha trishnaguha trishnaguha approved these changes

@justjais justjais justjais approved these changes

@rcarrillocruz rcarrillocruz Awaiting requested review from rcarrillocruz

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. iosxr Cisco IOSXR community module This issue/PR relates to a module. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@NilashishC @ansibot @trishnaguha @justjais @dagwieers