Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openssl_csr: ignore empty strings in altnames #51473

Merged
merged 4 commits into from
Feb 11, 2019
Merged

openssl_csr: ignore empty strings in altnames #51473

merged 4 commits into from
Feb 11, 2019

Conversation

felixfontein
Copy link
Contributor

@felixfontein felixfontein commented Jan 30, 2019 •
edited

SUMMARY

Fixes idempotence bug described in #51429.

Fixes #51429.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

openssl_csr

@ansibot
Copy link
Contributor

ansibot commented Jan 30, 2019

cc @Spredzy
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. small_patch support:community This issue/PR relates to code supported by the Ansible community. and removed small_patch labels Jan 30, 2019
@felixfontein
Copy link
Contributor Author

CC @MarkusTeufelberger @thomwiggers
(BTW: are you interested in also being notified about all, or at least some more of, the crypto modules when issues or PRs are created for them? If yes, I can create a PR to add you to the notify list.)

@dagwieers dagwieers added the crypto Crypto community (ACME, openssl, letsencrypt) label Feb 7, 2019
@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed needs_triage Needs a first human triage before being processed. labels Feb 7, 2019
@ansibot
Copy link
Contributor

ansibot commented Feb 9, 2019

cc @resmo @Spredzy
click here for bot help

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 9, 2019
resmo
resmo approved these changes Feb 10, 2019
View reviewed changes
Copy link
Contributor

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Feb 10, 2019
@gundalow gundalow merged commit 9b1cbcf into ansible:devel Feb 11, 2019
@gundalow
Copy link
Contributor

@felixfontein Thank you for the fix
@resmo Thanks for the review.
Merged into devel for release in Ansible 2.8

@felixfontein felixfontein deleted the openssl_csr-fix-idempotence branch February 11, 2019 10:35
felixfontein added a commit to felixfontein/ansible that referenced this pull request Feb 11, 2019
@felixfontein
openssl_csr: ignore empty strings in altnames (ansible#51473)
b63aff3 
* Ignore empty strings in altnames.

* Add changelog.

* Add idempotence check without SAN.

* Fix bug in cryptography backend.

(cherry picked from commit 9b1cbcf)
@felixfontein felixfontein mentioned this pull request Feb 11, 2019
Merged
@felixfontein
Copy link
Contributor Author

Thanks everyone! I created a backport to stable-2.7 in #52024.

abadger pushed a commit that referenced this pull request Feb 11, 2019
@felixfontein @abadger
openssl_csr: ignore empty strings in altnames (#51473)
0093b69 
* Ignore empty strings in altnames.

* Add changelog.

* Add idempotence check without SAN.

* Fix bug in cryptography backend.

(cherry picked from commit 9b1cbcf)
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@resmo resmo resmo approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. crypto Crypto community (ACME, openssl, letsencrypt) module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Idempotence test failed for openssl_csr
5 participants
@felixfontein @ansibot @gundalow @resmo @dagwieers