Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win_power_plan - move to Ansible.Basic and other fixes #51575

Merged
merged 1 commit into from
Jan 31, 2019
Merged

win_power_plan - move to Ansible.Basic and other fixes #51575

merged 1 commit into from
Jan 31, 2019

Conversation

jborean93
Copy link
Contributor

SUMMARY

Moves win_power_plan over to the Ansible.Basic framework now that #51471 has been merged and backported. Also fixes a slight issue around Set-ActivePowerPlan which were using variables defined outside of the cmdlet scope which worked but isn't really the correct way of doing things.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

win_power_plan

@ansibot
Copy link
Contributor

ansibot commented Jan 31, 2019

cc @dagwieers @jhawkesworth @nitzmahone @nwsparks
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. windows Windows community labels Jan 31, 2019
@jborean93 jborean93 merged commit 769c237 into ansible:devel Jan 31, 2019
@jborean93 jborean93 deleted the win_power_plan-basic branch January 31, 2019 22:07
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Feb 5, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jborean93 @ansibot @sivel