Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ansible.Basic: make module options case insensitive with dep warning #51583

Merged
merged 2 commits into from
Feb 14, 2019
Merged

Ansible.Basic: make module options case insensitive with dep warning #51583

merged 2 commits into from
Feb 14, 2019

Conversation

jborean93
Copy link
Contributor

SUMMARY

Historically module options for PowerShell modules are case insensitive. This PR makes sure the new AnsibleModule continues that behaviour but adds a warning saying this will be changed in a future Ansible version.

Fixes #51528

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/module_utils/csharp/Ansible.Basic.cs

@ansibot
Copy link
Contributor

ansibot commented Feb 1, 2019

cc @nitzmahone
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community labels Feb 1, 2019
@ansibot
Copy link
Contributor

ansibot commented Feb 1, 2019

cc @acozine
click here for bot help

@ansibot ansibot added the docs This issue/PR relates to or includes documentation. label Feb 1, 2019
@sivel sivel removed needs_triage Needs a first human triage before being processed. labels Feb 5, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 13, 2019
@jborean93
Copy link
Contributor Author

rebuild_merge

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Feb 14, 2019
@ansibot ansibot merged commit 7b8e814 into ansible:devel Feb 14, 2019
@jborean93 jborean93 deleted the win-basic-option-casing branch February 14, 2019 03:32
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. docs This issue/PR relates to or includes documentation. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ansible.Basic is case sensitive when validating input module names
3 participants
@jborean93 @ansibot @sivel