Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meraki_ssid - Modifying SSID won't work when specifying number #51645

Merged
merged 3 commits into from Feb 19, 2019
Merged

meraki_ssid - Modifying SSID won't work when specifying number #51645

merged 3 commits into from Feb 19, 2019

Conversation

kbreit
Copy link
Contributor

@kbreit kbreit commented Feb 2, 2019

SUMMARY

Fixed bug when specifying SSID by number and not name, execution didn't work

  • Migrated integration test to blocks with always
  • Minor URL fixes
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

meraki_ssid

@kbreit
Fix bug when specifying SSID by number
0b28876 
- Migrated integration test to blocks with always
- Minor URL fixes

(cherry picked from commit ed79c294f2e3f82d4828226004c055dcd7ce9f63)
@ansibot
Copy link
Contributor

ansibot commented Feb 2, 2019

cc @dagwieers
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. meraki Cisco Meraki community module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Feb 2, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 14, 2019
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 17, 2019
@dagwieers
Copy link
Contributor

rebuild_merge

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Feb 18, 2019
@ansibot ansibot merged commit 48128ec into ansible:devel Feb 19, 2019
@kbreit kbreit deleted the meraki/ssid_number_fix branch February 19, 2019 03:00
@dagwieers dagwieers added the cisco Cisco technologies label Feb 22, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cisco Cisco technologies meraki Cisco Meraki community module This issue/PR relates to a module. networking Network category shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kbreit @ansibot @dagwieers