Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding missing items in postgresql facts documentation #51677

Merged
merged 2 commits into from
Feb 11, 2019
Merged

adding missing items in postgresql facts documentation #51677

merged 2 commits into from
Feb 11, 2019

Conversation

zikalino
Copy link
Contributor

@zikalino zikalino commented Feb 3, 2019

SUMMARY

Just adding missing items in PostgreSQL facts documentation.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

azure_rm_postgresqlserver_facts

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Feb 3, 2019

cc @haroldwongms @nitzmahone @trstringer @xscript @yuwzho
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 azure cloud community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Feb 3, 2019
@ansibot
Copy link
Contributor

ansibot commented Feb 3, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_postgresqlserver_facts.py:126:32: W291 trailing whitespace

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Feb 3, 2019
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 4, 2019
@ansibleazurebot ansibleazurebot mentioned this pull request Feb 4, 2019
Closed
samccann
samccann approved these changes Feb 4, 2019
View reviewed changes
Copy link
Contributor

@samccann samccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs LGTM. Might need someone knowlegable about the module to verify the text is correct.

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Feb 4, 2019
@samccann samccann merged commit c581fbd into ansible:devel Feb 11, 2019
@samccann
Copy link
Contributor

@zikalino thanks for the Ansible documentation addition!

@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samccann samccann samccann approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 azure cloud community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zikalino @ansibot @samccann