Add support of facts gathering WWNs on AIX OS #51704

mator · 2019-02-04T18:22:37Z

SUMMARY

Add support of facts gathering WWNs on AIX OS

Extends #37043 / c65909d "Add network fact to obtain FC WWN initiator ports" for AIX support

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

facts module

ADDITIONAL INFORMATION

aix$ lsdev -Cc adapter -l fcs*
fcs0 Defined   00-00 8Gb PCI Express Dual Port FC Adapter
fcs1 Defined   00-01 8Gb PCI Express Dual Port FC Adapter
fcs2 Available 04-00 8Gb PCI Express Dual Port FC Adapter
fcs3 Available 04-01 8Gb PCI Express Dual Port FC Adapter

aix$ lscfg -vl fcs3 | grep "Network Address"
        Network Address.............10000090FA551509

before:

$ ansible -v vios8 -m setup -a "filter=ansible_fibre*"
Using /home/mator/ans/ansible.cfg as config file
vios8 | SUCCESS => {
    "ansible_facts": {
        "ansible_fibre_channel_wwn": []
    }, 
    "changed": false
}

after:

$ ansible vios8 -m setup -a "filter=ansible_fibre*"
vios8 | SUCCESS => {
    "ansible_facts": {
        "ansible_fibre_channel_wwn": [
            "10000090FA551508", 
            "10000090FA551509"
        ]
    }, 
    "changed": false
}

mator · 2019-02-04T19:51:27Z

if you remove failed OSX (runs almost for 1h , ssh returned 255 code), shippable ended ok (green)

mator · 2019-02-04T22:15:09Z

+label aix

dagwieers · 2019-02-13T11:02:09Z

cc @MorrisA @bcoca @flynn1973 @gforster @kairoaraujo @marvin-sinister @molekuul @wtcross

Please review and test !

gforster · 2019-03-27T16:20:39Z

Works as expected on AIX 7.1 and 7.2

mator · 2019-03-29T08:42:09Z

could probably rework a bit to remove grep filtering and use python instead , as well would not need to use unsafe_shell without grep.

if lscfg_out.find('Network Address') 
...

dagwieers · 2019-03-29T13:52:52Z

@mator Indeed, can you fix that grep, should be quite easy loop over lines.

ansibot · 2019-03-29T16:13:08Z

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/database/postgresql/postgresql_membership.py:0:0: E322 Argument 'ca_cert' is listed in the argument_spec, but not documented in the module documentation

click here for bot help

…r ports" adding support of enumerating AIX device WWN ports $ lsdev -Cc adapter -l fcs* fcs0 Defined 00-00 8Gb PCI Express Dual Port FC Adapter (df1000f114108a03) fcs1 Defined 00-01 8Gb PCI Express Dual Port FC Adapter (df1000f114108a03) fcs2 Available 04-00 8Gb PCI Express Dual Port FC Adapter (df1000f114108a03) fcs3 Available 04-01 8Gb PCI Express Dual Port FC Adapter (df1000f114108a03) $ lscfg -vpl fcs3 | grep 'Network Address' Network Address.............10000090FA551509

- fix run_command execution, passing 'use_unsafe_shell=True' since we have a pipe in it ( | grep ) if we don't set unsafe shell, it will return error on execution. - strip new line characters at the end of WWNs.

mator · 2019-04-09T14:12:29Z

ready_for_review

resmo

LGTM

gforster · 2019-04-10T21:50:59Z

7.1 & 7.2 check out

LGTM

_{Sent with GitHawk}

resmo · 2019-04-10T22:03:05Z

bot_status

ansibot · 2019-04-10T22:12:39Z

Components

changelogs/fragments/fibre_channel_wwn_fact_aix.yaml
support: community
maintainers:

lib/ansible/module_utils/facts/network/fc_wwn.py
support: core
maintainers:

Metadata

waiting_on: ansible
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 0
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 1
shipit_actors (maintainers or core team members): resmo
shipit_actors_other: gforster
automerge: automerge shipit test failed

click here for bot help

ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Feb 4, 2019

mator closed this Feb 4, 2019

mator reopened this Feb 4, 2019

gundalow added the aix AIX community label Feb 5, 2019

mator force-pushed the aix_wwn branch from 84102fa to 398ca52 Compare February 9, 2019 11:22

ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 10, 2019

s-hertel removed the needs_triage Needs a first human triage before being processed. label Feb 12, 2019

mator force-pushed the aix_wwn branch from 398ca52 to 5559434 Compare February 20, 2019 08:18

bcoca approved these changes Feb 20, 2019

View reviewed changes

mator force-pushed the aix_wwn branch from 618c397 to bc71301 Compare February 20, 2019 16:22

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 2, 2019

ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 29, 2019

ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Mar 29, 2019

mator force-pushed the aix_wwn branch from e220f82 to 38a7113 Compare March 29, 2019 21:57

ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 29, 2019

ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 6, 2019

mator added 9 commits April 9, 2019 16:23

no self in this code

579a7ac

Two fixes:

1ed789c

- fix run_command execution, passing 'use_unsafe_shell=True' since we have a pipe in it ( | grep ) if we don't set unsafe shell, it will return error on execution. - strip new line characters at the end of WWNs.

fix pep8 , E225 missing whitespace around operator

6afd132

use module.get_bin_path() instead of hardcoded values

2d61554

move module.get_bin_path() out of for loop

6489ae5

use python string parsing instead of calling external grep

f40b860

use in operator instead of find() for simplicity and readability

60dad3c

add changelog fragment

650d741

mator force-pushed the aix_wwn branch from 38a7113 to 650d741 Compare April 9, 2019 13:30

ansibot added support:community This issue/PR relates to code supported by the Ansible community. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Apr 9, 2019

resmo approved these changes Apr 10, 2019

View reviewed changes

resmo merged commit 19f6634 into ansible:devel Apr 10, 2019

mator deleted the aix_wwn branch April 11, 2019 11:04

ansible locked and limited conversation to collaborators Jul 25, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support of facts gathering WWNs on AIX OS #51704

Add support of facts gathering WWNs on AIX OS #51704

mator commented Feb 4, 2019 •

edited

mator commented Feb 4, 2019 •

edited

mator commented Feb 4, 2019

dagwieers commented Feb 13, 2019

gforster commented Mar 27, 2019

mator commented Mar 29, 2019 •

edited

dagwieers commented Mar 29, 2019

ansibot commented Mar 29, 2019

mator commented Apr 9, 2019

resmo left a comment

gforster commented Apr 10, 2019

resmo commented Apr 10, 2019

ansibot commented Apr 10, 2019

Add support of facts gathering WWNs on AIX OS #51704

Add support of facts gathering WWNs on AIX OS #51704

Conversation

mator commented Feb 4, 2019 • edited

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

mator commented Feb 4, 2019 • edited

mator commented Feb 4, 2019

dagwieers commented Feb 13, 2019

gforster commented Mar 27, 2019

mator commented Mar 29, 2019 • edited

dagwieers commented Mar 29, 2019

ansibot commented Mar 29, 2019

mator commented Apr 9, 2019

resmo left a comment

Choose a reason for hiding this comment

gforster commented Apr 10, 2019

resmo commented Apr 10, 2019

ansibot commented Apr 10, 2019

mator commented Feb 4, 2019 •

edited

mator commented Feb 4, 2019 •

edited

mator commented Mar 29, 2019 •

edited