Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Ansible UTM Info Module for proxy location entities. #51739

Merged
merged 1 commit into from Feb 21, 2019
Merged

Added Ansible UTM Info Module for proxy location entities. #51739

merged 1 commit into from Feb 21, 2019

Conversation

maunzCache
Copy link
Contributor

SUMMARY

This PR will add a new utm info module which allows the management of proxy location entries of the Sophos UTM. This module integrates with the existing utm_utils .

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME
  • module/web_infrastructure/sophos_utm/utm_proxy_location_info.py

- Fix sanity checks
  - Fixed documentation trailing whitespaces
@maunzCache
Copy link
Contributor Author

@stearz @RickS-C137 Please help out reviewing :)

@ansibot
Copy link
Contributor

ansibot commented Feb 5, 2019

@MatrixCrawler @example @stearz

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Feb 5, 2019

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. labels Feb 5, 2019
@MatrixCrawler
Copy link
Contributor

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Feb 5, 2019
@gundalow
Copy link
Contributor

team_e_spirit: MatrixCrawler getjack

Should that include @stearz @RickS-C137?

@gundalow
Copy link
Contributor

Also I see we are pinging @example could you please update #51739 (comment) to include the right person & GitHub ID

@maunzCache
Copy link
Contributor Author

Also I see we are pinging @example could you please update #51739 (comment) to include the right person & GitHub ID

ansible/lib/ansible/modules/web_infrastructure/sophos_utm/utm_network_interface_address.py

Line 20 in e053861

 - Juergen Wiebe (@example)

I wrongly included that user in one PR and none of my colleagues noticed that so i begged my colleague to create a github account be he's ill at the moment.

@ansibot ansibot added the web_infrastructure Web-infrastructure category label Feb 19, 2019
@gundalow
Copy link
Contributor

@getJack OK, should I mergethis PR as is, then in a follow up PR you can update BOTMETA and utm_network_interface_address.py?

@gundalow gundalow self-assigned this Feb 21, 2019
@gundalow gundalow merged commit 151ea2e into ansible:devel Feb 21, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 module This issue/PR relates to a module. new_module This PR includes a new module. new_plugin This PR includes a new plugin. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. web_infrastructure Web-infrastructure category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants