Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acme_challenge_cert_helper: fix bad module.fail_json() call #51795

Merged
merged 2 commits into from Feb 6, 2019
Merged

acme_challenge_cert_helper: fix bad module.fail_json() call #51795

merged 2 commits into from Feb 6, 2019

Conversation

felixfontein
Copy link
Contributor

SUMMARY

A tiny bugfix for acme_challenge_cert_helper: if cryptography was not found, it tried to call module.fail() instead of module.fail_json().

Found and fixed by @jborean93 in #51787, which will not be backported, hence this PR.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

acme_challenge_cert_helper

@ansibot
Copy link
Contributor

ansibot commented Feb 6, 2019

cc @Spredzy @resmo
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Feb 6, 2019
@jborean93 jborean93 merged commit c9b08db into ansible:devel Feb 6, 2019
@jborean93 jborean93 mentioned this pull request Feb 6, 2019
Merged
@felixfontein felixfontein deleted the acme-fix-module-fail branch February 6, 2019 06:45
@felixfontein
Copy link
Contributor Author

@jborean93 thanks again for spotting this, and thanks for handling this!

felixfontein added a commit to felixfontein/ansible that referenced this pull request Feb 6, 2019
@felixfontein
acme_challenge_cert_helper: fix bad module.fail_json() call (ansible#…
eb40b65 
…51795)

* Fix bad module.fail_json() call.

* Add changelog.

(cherry picked from commit c9b08db)
@felixfontein felixfontein mentioned this pull request Feb 6, 2019
Merged
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Feb 6, 2019
@dagwieers dagwieers added the crypto Crypto community (ACME, openssl, letsencrypt) label Feb 7, 2019
abadger pushed a commit that referenced this pull request Feb 11, 2019
@felixfontein @abadger
acme_challenge_cert_helper: fix bad module.fail_json() call (#51795)
a200cfb 
* Fix bad module.fail_json() call.

* Add changelog.

(cherry picked from commit c9b08db)
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. crypto Crypto community (ACME, openssl, letsencrypt) module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@felixfontein @ansibot @sivel @dagwieers @jborean93