Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes superfluous commands nxos_vlan #51796

Merged
merged 1 commit into from
Feb 8, 2019
Merged

Removes superfluous commands nxos_vlan #51796

merged 1 commit into from
Feb 8, 2019

Conversation

trishnaguha
Copy link
Member

@trishnaguha trishnaguha commented Feb 6, 2019 •
edited

Signed-off-by: Trishna Guha trishnaguha17@gmail.com

SUMMARY

Fixes #51745
At the end the vlan itself is always deleted for state being absent, vni removal is unnecessary.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

modules/network/nxos/nxos_vlan.py

@trishnaguha
Removes superfluous commands nxos_vlan
c393761 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@trishnaguha trishnaguha mentioned this pull request Feb 6, 2019
Closed
@trishnaguha trishnaguha self-assigned this Feb 6, 2019
@ansibot
Copy link
Contributor

ansibot commented Feb 6, 2019

cc @jedelman8 @mikewiebe @rahushen @rcarrillocruz @tstoner
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community owner_pr This PR is made by the module's maintainer. small_patch support:network This issue/PR relates to code supported by the Ansible Network Team. labels Feb 6, 2019
@Qalthos Qalthos mentioned this pull request Feb 6, 2019
Closed
@trishnaguha trishnaguha merged commit 88df4e2 into ansible:devel Feb 8, 2019
@trishnaguha trishnaguha deleted the nxos_vlan_fix branch February 8, 2019 05:40
@dagwieers dagwieers added the cisco Cisco technologies label Feb 22, 2019
trishnaguha added a commit to trishnaguha/ansible that referenced this pull request Apr 1, 2019
@trishnaguha
Removes superfluous commands nxos_vlan (ansible#51796)
2b1ac00 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 88df4e2)
abadger pushed a commit that referenced this pull request Apr 4, 2019
@trishnaguha @abadger
Removes superfluous commands nxos_vlan (#51796)
34cf510 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit 88df4e2)
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Qalthos Qalthos Qalthos approved these changes

Assignees

@trishnaguha trishnaguha

Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category nxos Cisco NXOS community owner_pr This PR is made by the module's maintainer. small_patch support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nxos failure on 9k when removing vlan (nxos_vlan absent)
4 participants
@trishnaguha @ansibot @Qalthos @dagwieers