Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use common functions for handling import errors #51851

Merged
merged 2 commits into from
Feb 7, 2019
Merged

Use common functions for handling import errors #51851

merged 2 commits into from
Feb 7, 2019

Conversation

jborean93
Copy link
Contributor

SUMMARY

Continuation of #51787

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

modules

@ansibot
Copy link
Contributor

ansibot commented Feb 7, 2019

cc @Akasurde @CiscoUcs @FragmentedPacket @KellerFuchs @Lunik @SDBrett @Shaps @abellotti @adrianmoisey @alcamie101 @amb1s1 @azaghal @bcoca @bgaifullin @bgurney-rh @cben @cloudnull @dagwieers @dankeder @dj-wasabi @drcapulet @dsoper2 @FragmentedPacket @garbled1 @goozbach @gtanzillo @haad @jcgruenhage @jirutka @jlozadad @johnamcdonough @jpmens @jtyr @makaimc @marwatk @mscherer @nbuchwitz @nerzhul @ogenstad @samdoran @sfromm @stpierre @tumbl3w33d @turb @vallard @vvb @waheedi @willybarro @yaacov @zgalor
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. gitlab Gitlab community module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. net_tools Net-tools category remote_management Working Group: https://docs.ansible.com/ansible/latest/community/communication.html selinux support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. ucs Cisco UCS community labels Feb 7, 2019
@cben
Copy link
Contributor

cben commented Feb 7, 2019

manageiq util looks fine 👍
shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. labels Feb 7, 2019
@Lunik Lunik mentioned this pull request Feb 7, 2019
Merged
@dagwieers dagwieers removed the gitlab Gitlab community label Feb 7, 2019
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed shipit This PR is ready to be merged by Core labels Feb 7, 2019
@jborean93
Copy link
Contributor Author

Looks like I rebased the gitlab modules incorrectly, need to fix that before merging.

@ansibot ansibot removed the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Feb 7, 2019
@jborean93
Copy link
Contributor Author

Done, gitlab modules are not longer being changed based on the recent refactor.

@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Feb 7, 2019
@ansibot ansibot added the core_review In order to be merged, this PR must follow the core review workflow. label Feb 7, 2019
@samdoran samdoran merged commit c1e51ef into ansible:devel Feb 7, 2019
@jborean93 jborean93 deleted the imp-error branch February 7, 2019 22:05
@dagwieers dagwieers added the cisco Cisco technologies label Feb 22, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samdoran samdoran samdoran approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. net_tools Net-tools category remote_management Working Group: https://docs.ansible.com/ansible/latest/community/communication.html selinux support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. ucs Cisco UCS community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jborean93 @ansibot @cben @samdoran @dagwieers