Fix copy module to reset filesystem acls #51868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
WIP
mkrizek
force-pushed
the
copy-acls2
branch
3 times, most recently
from
d7b6538
to
fbe63ef
Compare
mkrizek
changed the title
ansibot
added
core_review
s-hertel
removed
the
needs_triage
ansibot
added
the
stale_ci
This was referenced Mar 22, 2019
mkrizek
changed the title
ansibot
added
needs_revision
bcoca
requested changes
Mar 28, 2019
ansibot
removed
the
core_review
ansibot
added
the
needs_revision
The controller's fixup_perms2 uses filesystem acls to make the temporary file for copy readable by an unprivileged become user. On Python3, the acls are then copied to the destination filename so we have to remove them from there. We can't remove them prior to the copy because we may not have permission to read the file if the acls are not present. We can't remove them in atomic_move() because the move function shouldn't know anything about controller features. We may want to generalize this into a helper function, though. Fixes ansible#44412 Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
mkrizek
commented
Apr 2, 2019
bcoca
approved these changes
Apr 3, 2019
ansibot
added
core_review
mkrizek
added a commit
to mkrizek/ansible
that referenced
this pull request
Apr 3, 2019
The controller's fixup_perms2 uses filesystem acls to make the temporary file for copy readable by an unprivileged become user. On Python3, the acls are then copied to the destination filename so we have to remove them from there. We can't remove them prior to the copy because we may not have permission to read the file if the acls are not present. We can't remove them in atomic_move() because the move function shouldn't know anything about controller features. We may want to generalize this into a helper function, though. Fixes ansible#44412 Co-authored-by: Toshio Kuratomi <a.badger@gmail.com> (cherry picked from commit d15812f)
mkrizek
added a commit
to mkrizek/ansible
that referenced
this pull request
Apr 3, 2019
The controller's fixup_perms2 uses filesystem acls to make the temporary file for copy readable by an unprivileged become user. On Python3, the acls are then copied to the destination filename so we have to remove them from there. We can't remove them prior to the copy because we may not have permission to read the file if the acls are not present. We can't remove them in atomic_move() because the move function shouldn't know anything about controller features. We may want to generalize this into a helper function, though. Fixes ansible#44412 Co-authored-by: Toshio Kuratomi <a.badger@gmail.com> (cherry picked from commit d15812f)
mkrizek
added a commit
to mkrizek/ansible
that referenced
this pull request
Apr 3, 2019
The controller's fixup_perms2 uses filesystem acls to make the temporary file for copy readable by an unprivileged become user. On Python3, the acls are then copied to the destination filename so we have to remove them from there. We can't remove them prior to the copy because we may not have permission to read the file if the acls are not present. We can't remove them in atomic_move() because the move function shouldn't know anything about controller features. We may want to generalize this into a helper function, though. Fixes ansible#44412 Co-authored-by: Toshio Kuratomi <a.badger@gmail.com> (cherry picked from commit d15812f)
abadger
pushed a commit
that referenced
this pull request
Apr 4, 2019
The controller's fixup_perms2 uses filesystem acls to make the temporary file for copy readable by an unprivileged become user. On Python3, the acls are then copied to the destination filename so we have to remove them from there. We can't remove them prior to the copy because we may not have permission to read the file if the acls are not present. We can't remove them in atomic_move() because the move function shouldn't know anything about controller features. We may want to generalize this into a helper function, though. Fixes #44412 Co-authored-by: Toshio Kuratomi <a.badger@gmail.com> (cherry picked from commit d15812f)
abadger
pushed a commit
that referenced
this pull request
Apr 4, 2019
* Fix copy module to reset filesystem acls (#51868) The controller's fixup_perms2 uses filesystem acls to make the temporary file for copy readable by an unprivileged become user. On Python3, the acls are then copied to the destination filename so we have to remove them from there. We can't remove them prior to the copy because we may not have permission to read the file if the acls are not present. We can't remove them in atomic_move() because the move function shouldn't know anything about controller features. We may want to generalize this into a helper function, though. Fixes #44412 Co-authored-by: Toshio Kuratomi <a.badger@gmail.com> (cherry picked from commit d15812f) * Fix get_bin_path usage
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Alternative to #50419 and #51296
The controller's fixup_perms2 uses filesystem acls to make the temporary
file for copy readable by an unprivileged become user. On Python3, the
acls are then copied to the destination filename so we have to remove
them from there.
We can't remove them prior to the copy because we may not have
permission to read the file if the acls are not present. We can't
remove them in atomic_move() because the move function shouldn't know
anything about controller features. We may want to generalize this into
a helper function, though.
Fixes #44412
Co-authored-by: Toshio Kuratomi a.badger@gmail.com
ISSUE TYPE
COMPONENT NAME
copy
assemble
template
ADDITIONAL INFORMATION
The below action plugins use
_transfer_fileandfixup_perms2()too. However, the files that are transferred to the remote system are only kept in ansible temp dir and removed after they are used. Therefore it is not necessary to remove ACLs in those cases.