Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meraki_admin - Added recently added return fields for query #51876

Merged
merged 2 commits into from
Feb 19, 2019
Merged

meraki_admin - Added recently added return fields for query #51876

merged 2 commits into from
Feb 19, 2019

Conversation

kbreit
Copy link
Contributor

@kbreit kbreit commented Feb 7, 2019

SUMMARY

Meraki added some fields to their response for administrators so documentation has been updated to reflect this change. No code change, just documentation.

Fixes #51846

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

meraki_admin

@kbreit
Added recently added return fields for query
db1a889 
- Defined type of string for older fields too
@ansibot
Copy link
Contributor

ansibot commented Feb 7, 2019

cc @dagwieers
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. meraki Cisco Meraki community module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. labels Feb 7, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 15, 2019
@dagwieers
Copy link
Contributor

rebuild_merge

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Feb 18, 2019
@ansibot
Copy link
Contributor

ansibot commented Feb 19, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/network/meraki/meraki_admin.py:0:0: E325 Argument 'org_id' in argument_spec defines type as 'int' but documentation defines type as 'str'

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed shipit This PR is ready to be merged by Core labels Feb 19, 2019
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 19, 2019
@kbreit
Copy link
Contributor Author

kbreit commented Feb 19, 2019

@dagwieers I fixed the errors. Please review.

@acozine
Copy link
Contributor

acozine commented Feb 19, 2019

rebuild_merge

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Feb 19, 2019
@ansibot ansibot merged commit 9f7584e into ansible:devel Feb 19, 2019
@dagwieers dagwieers added the cisco Cisco technologies label Feb 22, 2019
@kbreit kbreit deleted the meraki/51846_docs_admin_fields branch March 23, 2019 18:19
kbreit added a commit to kbreit/ansible that referenced this pull request Apr 9, 2019
@kbreit
meraki_admin - Added recently added return fields for query (ansible#…
7c8a67e 
…51876)

* Added recently added return fields for query
- Defined type of string for older fields too

* Fix incorrect type for org_id

(cherry picked from commit 9f7584e)
acozine pushed a commit that referenced this pull request Apr 10, 2019
@kbreit @acozine
meraki_admin - Added recently added return fields for query (#51876) (#…
c5666e5 
…55048)

* Added recently added return fields for query
* Defined type of string for older fields too
* Fix incorrect type for org_id

(cherry picked from commit 9f7584e)
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 automerge This PR was automatically merged by ansibot. cisco Cisco technologies docs This issue/PR relates to or includes documentation. meraki Cisco Meraki community module This issue/PR relates to a module. networking Network category owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

meraki_admin - Add new fields returned by Meraki
4 participants
@kbreit @ansibot @dagwieers @acozine