include_vars: include main.yml #51926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.8
s-hertel
removed
the
needs_triage
ansibot
added
core_review
|
@sivel Could you please take a look ? Thanks. |
ansibot
added
the
stale_ci
|
LGTM, but if we are planning to backport at all, this would need a changelog. |
Enhance the conditional check to include main.yml if it is not from 'role/vars/' Fixes: ansible#29135 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
ansibot
added
support:community
|
@sivel I added changelog before merging. Thanks for the review. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Enhance the conditional check to include main.yml if it is not
from 'role/vars/'
Fixes: #29135
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com
ISSUE TYPE
COMPONENT NAME
lib/ansible/plugins/action/include_vars.py