Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSO - added validate_certs parameter to allow for ignoring of SSL certificates #51981

Merged
merged 4 commits into from
Feb 25, 2019
Merged

NSO - added validate_certs parameter to allow for ignoring of SSL certificates #51981

merged 4 commits into from
Feb 25, 2019

Conversation

tsavery-DD
Copy link
Contributor

@tsavery-DD tsavery-DD commented Feb 8, 2019 •
edited

SUMMARY

Adds a validate_certs parameter to the NSO module that allows the option of ignoring SSL certificates when using an NSO instance with SSL enabled.

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

NSO

ADDITIONAL INFORMATION

validate_certs defaults to false, when true it will validate SSL certificates when connecting to NSO. This can be reversed to default to true if it will create compatibility problems with existing playbooks.

@ansibot
Copy link
Contributor

ansibot commented Feb 8, 2019

cc @cmoberg @cnasten @tbjurman
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. networking Network category new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. labels Feb 8, 2019
@tsavery-DD tsavery-DD changed the title added validate_certs parameter to allow for ignoring of SSL certificates NSO - added validate_certs parameter to allow for ignoring of SSL certificates Feb 8, 2019
@ansibot
Copy link
Contributor

ansibot commented Feb 8, 2019

cc @NilashishC @Qalthos @ganeshrn @gdpak @justjais @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Feb 8, 2019
@tsavery-DD
Copy link
Contributor Author

ready_for_review

@tsavery-DD
Copy link
Contributor Author

Whats the process to get this reviewed and merged? It seems like the NSO module maintainers are inactive and I've yet to receive any feedback on this PR.

@dagwieers dagwieers added nso Cisco NSO community cisco Cisco technologies labels Feb 22, 2019
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. labels Feb 22, 2019
@ansibot ansibot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Feb 22, 2019
@tsavery-DD tsavery-DD closed this Feb 22, 2019
@tsavery-DD tsavery-DD reopened this Feb 22, 2019
@tsavery-DD tsavery-DD closed this Feb 22, 2019
@tsavery-DD tsavery-DD reopened this Feb 22, 2019
@tsavery-DD tsavery-DD closed this Feb 22, 2019
@tsavery-DD tsavery-DD reopened this Feb 22, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 22, 2019
@cnasten
Copy link
Contributor

cnasten commented Feb 24, 2019

shipit

1 similar comment
@tbjurman
Copy link

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. labels Feb 24, 2019
@gundalow gundalow merged commit 1f7ffe2 into ansible:devel Feb 25, 2019
@gundalow
Copy link
Contributor

Thanks, merged into devel for release in Ansible 2.8

@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 cisco Cisco technologies feature This issue/PR relates to a feature request. networking Network category new_contributor This PR is the first contribution by a new community member. nso Cisco NSO community shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tsavery-DD @ansibot @cnasten @tbjurman @gundalow @dagwieers