Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flatpak_remote: Handle empty output in remote_exists #52010

Merged
merged 1 commit into from
Feb 18, 2019
Merged

flatpak_remote: Handle empty output in remote_exists #52010

merged 1 commit into from
Feb 18, 2019

Conversation

vespian
Copy link
Contributor

@vespian vespian commented Feb 10, 2019 •
edited

SUMMARY

flatpak remote-list -d can return an empty output, it should be handled gracefully

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

flatpak_remote

ADDITIONAL INFORMATION
  • Fedora 29
  • flatpak version 1.2.0
  • python3
  • ansible 2.7.5

@vespian
flatpak_remote: Handle empty output in remote_exists
277d0ac 
`flatpak remote-list -d` can return an empty output on Fedora 29 (version 1.2.0).
@ansibot
Copy link
Contributor

ansibot commented Feb 10, 2019

cc @JayKayy @oolongbrothers
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. python3 small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Feb 10, 2019
@gundalow gundalow merged commit fcb6f13 into ansible:devel Feb 18, 2019
@gundalow
Copy link
Contributor

Thanks!

@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Feb 18, 2019
@vespian vespian deleted the patch-1 branch February 19, 2019 19:13
@oolongbrothers
Copy link
Contributor

Thanks for your effort!
However, flagging duplication of effort here:
I had a pull request fixing this open since Jan 30th #51482
I am really having a hard time trying to maintain this module.

This was referenced Feb 20, 2019
Closed
Merged
oolongbrothers pushed a commit to oolongbrothers/ansible that referenced this pull request Mar 20, 2019
@vespian @oolongbrothers
flatpak_remote: Handle empty output in remote_exists (ansible#52010)
d78b342 
`flatpak remote-list -d` can return an empty output on Fedora 29 (version 1.2.0).

(cherry picked from commit fcb6f13)
@oolongbrothers oolongbrothers mentioned this pull request Mar 20, 2019
Merged
abadger pushed a commit that referenced this pull request Mar 22, 2019
@oolongbrothers @abadger
Handle empty output in remote_exists (backport of #52010 to 2.7) (#54103
9173941 
)

* flatpak_remote: Handle empty output in remote_exists (#52010)

`flatpak remote-list -d` can return an empty output on Fedora 29 (version 1.2.0).

(cherry picked from commit fcb6f13)

* Adds changelog fragment for 52010 backport
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. new_contributor This PR is the first contribution by a new community member. python3 small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vespian @ansibot @gundalow @oolongbrothers @sivel