Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BOTMETA: Add ProxySQL to $team_mysql #52054

Merged
merged 1 commit into from
Feb 22, 2019
Merged

BOTMETA: Add ProxySQL to $team_mysql #52054

merged 1 commit into from
Feb 22, 2019

Conversation

dagwieers
Copy link
Contributor

SUMMARY

Thanks to @timorunge
This relates to #51374 (comment).

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

proxysql

This was referenced Feb 12, 2019
Merged
Closed
@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Feb 12, 2019
@dagwieers dagwieers changed the title Add ProxySQL to $team_mysql BOTMETA: Add ProxySQL to $team_mysql Feb 12, 2019
@dagwieers dagwieers force-pushed the proxysql-team_mysql branch 2 times, most recently from 20eb66b to 8cc5471 Compare February 12, 2019 11:44
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Feb 15, 2019
@bmalynovytch
Copy link
Contributor

@dagwieers could you rebase ? :)

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 15, 2019
gundalow
gundalow requested changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update is good, though on hold as we are fighting some Bot issues at the moment

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Feb 19, 2019
@dagwieers dagwieers added the botmeta This PR modifies the BOTMETA.yml and this requires special attention! label Feb 21, 2019
@dagwieers
BOTMETA: Add ProxySQL to $team_mysql
caef5b2 
ProxySQL uses mysql module_utils so becomes part of MySQL WG.
@ansibot ansibot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 22, 2019
@ansibot ansibot added the core_review In order to be merged, this PR must follow the core review workflow. label Feb 22, 2019
@dagwieers
Copy link
Contributor Author

rebuild_merge

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. labels Feb 22, 2019
@ansibot ansibot merged commit 4e6ca4b into ansible:devel Feb 22, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

@bmalynovytch bmalynovytch bmalynovytch approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 botmeta This PR modifies the BOTMETA.yml and this requires special attention! docs This issue/PR relates to or includes documentation. mysql shipit This PR is ready to be merged by Core support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dagwieers @bmalynovytch @gundalow @ansibot