Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install the NuGet package provider if needed #52130

Merged
merged 2 commits into from
Feb 14, 2019

Conversation

it-praktyk
Copy link
Contributor

SUMMARY

Under adding a repository the NuGet package provider in the version 2.8.5.201 or newer is required. When it's not available the win_psrepository fails.

Fixes partially #50332 - for Ansible 2.6.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_psmodule

ADDITIONAL INFORMATION

It's a backport of the #50759 - the win_psrepository module is a descendant of the win_psmodule.

Additionally, the pull requests remove some code smells.

@ansibot
Copy link
Contributor

ansibot commented Feb 12, 2019

@ansibot ansibot added affects_2.6 This issue/PR affects Ansible v2.6 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. windows Windows community labels Feb 12, 2019
@abadger
Copy link
Contributor

abadger commented Feb 13, 2019

This needs a changelog fragment saying what's being fixed before it can be merged. How to create a changelog is listed here: https://docs.ansible.com/ansible/latest/reference_appendices/release_and_maintenance.html#changelogs-how-to

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Feb 13, 2019
@abadger abadger merged commit bec375d into ansible:stable-2.6 Feb 14, 2019
@abadger
Copy link
Contributor

abadger commented Feb 14, 2019

Merged for the 2.6.14 release.

@it-praktyk it-praktyk deleted the stable-2.6-backport_50759 branch February 14, 2019 23:03
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.6 This issue/PR affects Ansible v2.6 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. windows Windows community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants