Allow user to specify a custom condition when waiting

[fabianvf]

SUMMARY

This allows users to specify a custom condition to wait for when using the k8s module. This provides a similar functionality to the kubectl wait command. This is one option, I'm working on another option right now which is a specify k8s_wait module that allows some more flexibility and keeps the k8s module slimmer.

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

k8s

[ansibot]

cc @chouseknecht @flaper87 @maxamillion @willthames
click here for bot help

[willthames]

This is pretty nice. I was skeptical, as my feelings are that you could easily do this with k8s_facts and retries but this is significantly more elegant than that, and reuses existing functionality.

Does this need to work with nested keys? (I have no idea if it needs to, looks like most status keys are top level)

[fabianvf]

In its current state, this will only work with conditions, not top-level fields (I focused on conditions because they're a bit hellish to parse, especially in Ansible). The k8s_wait module in #52274 supports comparison on arbitrary fields, but feels wrong. Still thinking about different ways to do this.

[fabianvf]

ping @willthames, look good to you? I'd like to get this in for 2.8 if possible

[maxamillion]

shipit

[fabianvf]

bot_status

[ansibot]

Components

lib/ansible/module_utils/k8s/raw.py
support: community
maintainers: chouseknecht fabianvf flaper87 maxamillion willthames

lib/ansible/modules/clustering/k8s/k8s.py
support: community
maintainers: chouseknecht fabianvf flaper87 maxamillion willthames

test/integration/targets/k8s/playbooks/roles/k8s/tasks/waiter.yml
support: community
maintainers: chouseknecht fabianvf flaper87 maxamillion willthames

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 1
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 1
shipit_actors (maintainers or core team members): maxamillion fabianvf
shipit_actors_other: []
automerge: automerge !module file(s) test failed

click here for bot help

[gundalow]

Thanks all, merged into devel for release in Ansible 2.8

As long as label/shipit is added we get these merged within the week. #52185 (comment)