Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge doc fragments in earlier #52193

Merged
merged 4 commits into from
Feb 19, 2019
Merged

Merge doc fragments in earlier #52193

merged 4 commits into from
Feb 19, 2019

Conversation

sivel
Copy link
Member

@sivel sivel commented Feb 13, 2019

SUMMARY

Merge in doc fragments earlier.

See #52069 (comment)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

test/sanity/validate-modules/main.py

ADDITIONAL INFORMATION

@sivel sivel requested a review from mattclay February 13, 2019 20:16
@ansibot
Copy link
Contributor

ansibot commented Feb 13, 2019

cc @gundalow @mattclay
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Feb 13, 2019
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Feb 13, 2019
@ansibot
Copy link
Contributor

ansibot commented Feb 13, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 15 errors:

lib/ansible/modules/storage/netapp/netapp_e_alerts.py:0:0: E305 DOCUMENTATION.options.api_url.example: extra keys not allowed @ data['options']['api_url']['example']. Got ['https://prod-1.wahoo.acme.com/devmgr/v2']
lib/ansible/modules/storage/netapp/netapp_e_amg.py:0:0: E305 DOCUMENTATION.options.api_url.example: extra keys not allowed @ data['options']['api_url']['example']. Got ['https://prod-1.wahoo.acme.com/devmgr/v2']
lib/ansible/modules/storage/netapp/netapp_e_asup.py:0:0: E305 DOCUMENTATION.options.api_url.example: extra keys not allowed @ data['options']['api_url']['example']. Got ['https://prod-1.wahoo.acme.com/devmgr/v2']
lib/ansible/modules/storage/netapp/netapp_e_auditlog.py:0:0: E305 DOCUMENTATION.options.api_url.example: extra keys not allowed @ data['options']['api_url']['example']. Got ['https://prod-1.wahoo.acme.com/devmgr/v2']
lib/ansible/modules/storage/netapp/netapp_e_global.py:0:0: E305 DOCUMENTATION.options.api_url.example: extra keys not allowed @ data['options']['api_url']['example']. Got ['https://prod-1.wahoo.acme.com/devmgr/v2']
lib/ansible/modules/storage/netapp/netapp_e_host.py:0:0: E305 DOCUMENTATION.options.api_url.example: extra keys not allowed @ data['options']['api_url']['example']. Got ['https://prod-1.wahoo.acme.com/devmgr/v2']
lib/ansible/modules/storage/netapp/netapp_e_iscsi_interface.py:0:0: E305 DOCUMENTATION.options.api_url.example: extra keys not allowed @ data['options']['api_url']['example']. Got ['https://prod-1.wahoo.acme.com/devmgr/v2']
lib/ansible/modules/storage/netapp/netapp_e_iscsi_target.py:0:0: E305 DOCUMENTATION.options.api_url.example: extra keys not allowed @ data['options']['api_url']['example']. Got ['https://prod-1.wahoo.acme.com/devmgr/v2']
lib/ansible/modules/storage/netapp/netapp_e_ldap.py:0:0: E305 DOCUMENTATION.options.api_url.example: extra keys not allowed @ data['options']['api_url']['example']. Got ['https://prod-1.wahoo.acme.com/devmgr/v2']
lib/ansible/modules/storage/netapp/netapp_e_lun_mapping.py:0:0: E305 DOCUMENTATION.options.api_url.example: extra keys not allowed @ data['options']['api_url']['example']. Got ['https://prod-1.wahoo.acme.com/devmgr/v2']
lib/ansible/modules/storage/netapp/netapp_e_mgmt_interface.py:0:0: E305 DOCUMENTATION.options.api_url.example: extra keys not allowed @ data['options']['api_url']['example']. Got ['https://prod-1.wahoo.acme.com/devmgr/v2']
lib/ansible/modules/storage/netapp/netapp_e_storagepool.py:0:0: E305 DOCUMENTATION.options.api_url.example: extra keys not allowed @ data['options']['api_url']['example']. Got ['https://prod-1.wahoo.acme.com/devmgr/v2']
lib/ansible/modules/storage/netapp/netapp_e_syslog.py:0:0: E305 DOCUMENTATION.options.api_url.example: extra keys not allowed @ data['options']['api_url']['example']. Got ['https://prod-1.wahoo.acme.com/devmgr/v2']
lib/ansible/modules/storage/netapp/netapp_e_volume.py:0:0: E305 DOCUMENTATION.options.api_url.example: extra keys not allowed @ data['options']['api_url']['example']. Got ['https://prod-1.wahoo.acme.com/devmgr/v2']
lib/ansible/modules/storage/netapp/netapp_e_volume_copy.py:0:0: E305 DOCUMENTATION.options.api_url.example: extra keys not allowed @ data['options']['api_url']['example']. Got ['https://prod-1.wahoo.acme.com/devmgr/v2']

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Feb 13, 2019
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Feb 14, 2019
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Feb 14, 2019
@ansibot
Copy link
Contributor

ansibot commented Feb 14, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 15 errors:

lib/ansible/modules/storage/netapp/netapp_e_alerts.py:0:0: E305 DOCUMENTATION.options.api_url.example: extra keys not allowed @ data['options']['api_url']['example']. Got ['https://prod-1.wahoo.acme.com/devmgr/v2']
lib/ansible/modules/storage/netapp/netapp_e_amg.py:0:0: E305 DOCUMENTATION.options.api_url.example: extra keys not allowed @ data['options']['api_url']['example']. Got ['https://prod-1.wahoo.acme.com/devmgr/v2']
lib/ansible/modules/storage/netapp/netapp_e_asup.py:0:0: E305 DOCUMENTATION.options.api_url.example: extra keys not allowed @ data['options']['api_url']['example']. Got ['https://prod-1.wahoo.acme.com/devmgr/v2']
lib/ansible/modules/storage/netapp/netapp_e_auditlog.py:0:0: E305 DOCUMENTATION.options.api_url.example: extra keys not allowed @ data['options']['api_url']['example']. Got ['https://prod-1.wahoo.acme.com/devmgr/v2']
lib/ansible/modules/storage/netapp/netapp_e_global.py:0:0: E305 DOCUMENTATION.options.api_url.example: extra keys not allowed @ data['options']['api_url']['example']. Got ['https://prod-1.wahoo.acme.com/devmgr/v2']
lib/ansible/modules/storage/netapp/netapp_e_host.py:0:0: E305 DOCUMENTATION.options.api_url.example: extra keys not allowed @ data['options']['api_url']['example']. Got ['https://prod-1.wahoo.acme.com/devmgr/v2']
lib/ansible/modules/storage/netapp/netapp_e_iscsi_interface.py:0:0: E305 DOCUMENTATION.options.api_url.example: extra keys not allowed @ data['options']['api_url']['example']. Got ['https://prod-1.wahoo.acme.com/devmgr/v2']
lib/ansible/modules/storage/netapp/netapp_e_iscsi_target.py:0:0: E305 DOCUMENTATION.options.api_url.example: extra keys not allowed @ data['options']['api_url']['example']. Got ['https://prod-1.wahoo.acme.com/devmgr/v2']
lib/ansible/modules/storage/netapp/netapp_e_ldap.py:0:0: E305 DOCUMENTATION.options.api_url.example: extra keys not allowed @ data['options']['api_url']['example']. Got ['https://prod-1.wahoo.acme.com/devmgr/v2']
lib/ansible/modules/storage/netapp/netapp_e_lun_mapping.py:0:0: E305 DOCUMENTATION.options.api_url.example: extra keys not allowed @ data['options']['api_url']['example']. Got ['https://prod-1.wahoo.acme.com/devmgr/v2']
lib/ansible/modules/storage/netapp/netapp_e_mgmt_interface.py:0:0: E305 DOCUMENTATION.options.api_url.example: extra keys not allowed @ data['options']['api_url']['example']. Got ['https://prod-1.wahoo.acme.com/devmgr/v2']
lib/ansible/modules/storage/netapp/netapp_e_storagepool.py:0:0: E305 DOCUMENTATION.options.api_url.example: extra keys not allowed @ data['options']['api_url']['example']. Got ['https://prod-1.wahoo.acme.com/devmgr/v2']
lib/ansible/modules/storage/netapp/netapp_e_syslog.py:0:0: E305 DOCUMENTATION.options.api_url.example: extra keys not allowed @ data['options']['api_url']['example']. Got ['https://prod-1.wahoo.acme.com/devmgr/v2']
lib/ansible/modules/storage/netapp/netapp_e_volume.py:0:0: E305 DOCUMENTATION.options.api_url.example: extra keys not allowed @ data['options']['api_url']['example']. Got ['https://prod-1.wahoo.acme.com/devmgr/v2']
lib/ansible/modules/storage/netapp/netapp_e_volume_copy.py:0:0: E305 DOCUMENTATION.options.api_url.example: extra keys not allowed @ data['options']['api_url']['example']. Got ['https://prod-1.wahoo.acme.com/devmgr/v2']

click here for bot help

@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Feb 15, 2019
@ansibot
Copy link
Contributor

ansibot commented Feb 17, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/network/asa/asa_acl.py:0:0: E305 DOCUMENTATION.options.provider.suboptions.host.type: not a valid value for dictionary value @ data['options']['provider']['suboptions']['host']['type']. Got 'host'
lib/ansible/modules/network/asa/asa_command.py:0:0: E305 DOCUMENTATION.options.provider.suboptions.host.type: not a valid value for dictionary value @ data['options']['provider']['suboptions']['host']['type']. Got 'host'
lib/ansible/modules/network/asa/asa_config.py:0:0: E305 DOCUMENTATION.options.provider.suboptions.host.type: not a valid value for dictionary value @ data['options']['provider']['suboptions']['host']['type']. Got 'host'

click here for bot help

@ansibot ansibot added small_patch support:community This issue/PR relates to code supported by the Ansible community. and removed ci_verified Changes made in this PR are causing tests to fail. labels Feb 17, 2019
@sivel sivel merged commit b54086e into ansible:devel Feb 19, 2019
@resmo resmo mentioned this pull request Feb 20, 2019
Closed
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattclay mattclay mattclay approved these changes

@gundalow gundalow gundalow approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. small_patch support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sivel @ansibot @mattclay @gundalow