Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use distro.id() instead of distro.name() #52199

Merged
merged 5 commits into from
Mar 7, 2019
Merged

Use distro.id() instead of distro.name() #52199

merged 5 commits into from
Mar 7, 2019

Conversation

samdoran
Copy link
Contributor

SUMMARY
  • distro.id() is a more reliable way to determine the distribution than using distro.name() and works with existing class name lookup methods.
  • Change logic around Amazon linux parsing.
  • Update tests based on new method behavior.

Fixes #50844
Closes #50847

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/module_utils/common/sys_info.py

ADDITIONAL INFORMATION

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Feb 13, 2019
@mattclay
Copy link
Member

CI failure in unit tests: https://app.shippable.com/github/ansible/ansible/runs/107340/8/tests

@mattclay mattclay added ci_verified Changes made in this PR are causing tests to fail. and removed needs_triage Needs a first human triage before being processed. labels Feb 14, 2019
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Feb 14, 2019
@samdoran samdoran added this to Needs Review - This is when code is complete and needs review. in Ansible 2.8 Feb 21, 2019
@samdoran samdoran mentioned this pull request Feb 22, 2019
Merged
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 26, 2019
@samdoran samdoran mentioned this pull request Mar 4, 2019
Merged
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. core_review In order to be merged, this PR must follow the core review workflow. labels Mar 5, 2019
@ansibot
Copy link
Contributor

ansibot commented Mar 5, 2019

cc @alikins @saito-hideki
click here for bot help

@ansibot ansibot added module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. system System category and removed small_patch labels Mar 5, 2019
@samdoran
Use distro.id() instead of distro.name()
ca0be79 
- update unit tests to reflect new method behoior
@samdoran
Update unit sys_info unit tests
f78b754
@samdoran
Use correct string in url.py
a909b6f 
I'm not sure 'redhat' was correct before but 'rhel' is definitely correct now.
@samdoran
Correct distribution values in hostname.py
f2ea0de 
I verified the majority of these.
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 6, 2019
@samdoran samdoran added the P2 Priority 2 - Issue Blocks Release label Mar 6, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 7, 2019
@samdoran samdoran merged commit bf28b5c into ansible:devel Mar 7, 2019
@samdoran samdoran deleted the issue/50844-distro-id branch March 7, 2019 18:26
@thaumos thaumos moved this from Needs Review - This is when code is complete and needs review. to Done - This means done, tests, integration, everything... obvi. in Ansible 2.8 Mar 7, 2019
@dakira
Copy link

dakira commented Apr 23, 2019 •
edited

This causes a regression with Sangoma-Linux. It is now not being detected anymore. @samdoran, can you fix this or tell me how I can help to fix this?

@samdoran
Copy link
Contributor Author

@dakira Can you run a hostname task with Ansible 2.8 and paste the "hostname module cannot be used on platform X" result in #42726? Or open a new issue if #42726 is not related to what you are seeing.

@dakira dakira mentioned this pull request May 23, 2019
Closed
@ericpulvino ericpulvino mentioned this pull request Jun 6, 2019
Merged
ericpulvino added a commit to ericpulvino/ansible that referenced this pull request Jun 7, 2019
@ericpulvino
Fixes lack of support for Cumulus Linux with Hostname module in Ansib…
5fed51b 
…le v2.8.0. Broken in Pull Request ansible#52199.
@ericpulvino ericpulvino mentioned this pull request Jun 10, 2019
Merged
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sivel sivel sivel left review comments

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. P2 Priority 2 - Issue Blocks Release support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. system System category
Projects
No open projects
Ansible 2.8
  
Done - This means done, tests, integr...
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression hostname module ArchLinux, Alpine, Devuan, ...
5 participants
@samdoran @mattclay @ansibot @dakira @sivel