Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tcp_max_xfer_size option for na_ontap_nfs, plus unit test #52288

Merged
merged 6 commits into from
Mar 5, 2019
Merged

Add tcp_max_xfer_size option for na_ontap_nfs, plus unit test #52288

merged 6 commits into from
Mar 5, 2019

Conversation

carchi8py
Copy link
Contributor

SUMMARY

Add tcp_max_xfer_size option for na_ontap_nfs
Adds unit tests for na_ontap_nfs

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • na_ontap_nfs.py
ADDITIONAL INFORMATION

carchi8py and others added 4 commits February 14, 2019 09:41
@carchi8py
Revert "changes to clusteR"
8e56b99 
This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.
@carchi8py
updates
67195a1
@carchi8py
Revert "Revert "changes to clusteR""
b20f0fa 
This reverts commit 8e56b99.
@carchi8py
fix docs
28ddaf9
@ansibot
Copy link
Contributor

ansibot commented Feb 14, 2019

cc @amit0701 @hulquest @lmprice @lonico @ndswartz @schmots1
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. netapp storage support:certified This issue/PR relates to certified code. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Feb 14, 2019
lonico
lonico approved these changes Feb 15, 2019
View reviewed changes
Copy link
Contributor

@lonico lonico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

lib/ansible/modules/storage/netapp/na_ontap_nfs.py Outdated Show resolved Hide resolved
@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. labels Feb 15, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed shipit This PR is ready to be merged by Core labels Feb 17, 2019
lonico
lonico approved these changes Feb 20, 2019
View reviewed changes
Copy link
Contributor

@lonico lonico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. labels Feb 20, 2019
thedoubl3j
thedoubl3j approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@thedoubl3j thedoubl3j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new option and docs look good, tests as always a plus. lgtm

@gundalow @carchi8py
Update lib/ansible/modules/storage/netapp/na_ontap_nfs.py
2511998 
Co-Authored-By: carchi8py <carchi@netapp.com>
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed shipit This PR is ready to be merged by Core labels Mar 4, 2019
@gundalow gundalow merged commit af6e4cc into ansible:devel Mar 5, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thedoubl3j thedoubl3j thedoubl3j approved these changes

@gundalow gundalow gundalow approved these changes

@lonico lonico lonico approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. netapp storage support:certified This issue/PR relates to certified code. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@carchi8py @ansibot @gundalow @lonico @thedoubl3j