fixing force_update in azure_rm_mysqldatabase #52389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.8
yungezz
reviewed
Feb 18, 2019
| - name: Assert the state has not changed | ||
| assert: | ||
| that: | ||
| - output.changed == false |
There was a problem hiding this comment.
shouldn't the updating failed? if no update happens?
There was a problem hiding this comment.
that's a good question. according to current documentation it should not.
I am considering adding a warning (as we discussed already regarding unchangeable properties).
ansibot
removed
the
needs_triage
yungezz
approved these changes
Feb 18, 2019
|
shipit |
zikalino
pushed a commit
to VSChina/ansible
that referenced
this pull request
Feb 18, 2019
(cherry picked from commit fa73abc)
abadger
pushed a commit
that referenced
this pull request
Feb 18, 2019
(cherry picked from commit fa73abc)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Module was crashing when trying to update and use force_update
ISSUE TYPE
COMPONENT NAME
azure_rm_mysqldatabase
ADDITIONAL INFORMATION