Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rhevm: Refactor & fix validate-modules issues #52436

Merged
merged 1 commit into from
Mar 6, 2019
Merged

rhevm: Refactor & fix validate-modules issues #52436

merged 1 commit into from
Mar 6, 2019

Conversation

dagwieers
Copy link
Contributor

SUMMARY

This PR includes:

  • Adding parameter types
  • Fix validate-modules issue
  • Improve parameter types and resulting changes

This PR needs to be verified and tested by maintainer(s).

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME

rhevm

@ansibot
Copy link
Contributor

ansibot commented Feb 18, 2019

cc @timothyvandenbrande @joshainglis @karmab @machacekondra @mattclay @mwperina
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) labels Feb 18, 2019
@dagwieers
Copy link
Contributor Author

The CI failure is related to an undocumented parameter that I added.

@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Feb 18, 2019
@dagwieers dagwieers removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. labels Feb 18, 2019
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Feb 20, 2019
@dagwieers dagwieers added ovirt oVirt and RHV community and removed virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) labels Feb 21, 2019
@gundalow gundalow changed the title rhevm: Fix validate-modules issues rhevm: Refactor & fix validate-modules issues Feb 22, 2019
@dagwieers
rhevm: Fix validate-modules issues
73ead1b 
This PR includes:

* Adding parameter types
* Fix validate-modules issue
* Improve parameter types and resulting changes

This PR needs to be verified and tested by maintainer(s).
@dagwieers
Copy link
Contributor Author

@gundalow This code has not been refactored. The only change is turning a string into a proper integer, which at best is a fix.

@dagwieers dagwieers removed the ci_verified Changes made in this PR are causing tests to fail. label Feb 25, 2019
mwperina
mwperina approved these changes Feb 25, 2019
View reviewed changes
Copy link
Contributor

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ansibot
Copy link
Contributor

ansibot commented Feb 25, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/misc/rhevm.py:0:0: E309 version_added for new option (password) should be '2.8'. Currently StrictVersion ('0.0')

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 25, 2019
@dagwieers dagwieers removed the support:core This issue/PR relates to code supported by the Ansible Engineering Team. label Feb 27, 2019
@ansibot ansibot added the support:core This issue/PR relates to code supported by the Ansible Engineering Team. label Feb 27, 2019
@dagwieers
Copy link
Contributor Author

@gundalow Can this one be merged ?

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 5, 2019
@gundalow
Copy link
Contributor

gundalow commented Mar 6, 2019

rebuild_merge

@dagwieers
Copy link
Contributor Author

That won't work because the tests are expected to fail.

The CI failure is related to an undocumented parameter that I added.

@gundalow
Copy link
Contributor

gundalow commented Mar 6, 2019

Only CI failure is

lib/ansible/modules/cloud/misc/rhevm.py:0:0: E309 version_added for new option (password) should be '2.8'. Currently StrictVersion ('0.0')

Merging

@gundalow gundalow merged commit c44e83e into ansible:devel Mar 6, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow approved these changes

@mwperina mwperina mwperina approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. ci_verified Changes made in this PR are causing tests to fail. cloud module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. ovirt oVirt and RHV community stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dagwieers @ansibot @gundalow @mwperina @mattclay