Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate-modules: Fix some files modules #52440

Merged
merged 1 commit into from
Feb 25, 2019
Merged

validate-modules: Fix some files modules #52440

merged 1 commit into from
Feb 25, 2019

Conversation

dagwieers
Copy link
Contributor

SUMMARY

This PR includes:

  • fixes to validate-modules issues

All modules already include parameter types.

The remaining files-modules have action plugins, so comparing to the arg_spec only is incorrect.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

lineinfile
synchronize

@ansibot
Copy link
Contributor

ansibot commented Feb 18, 2019

cc @Akasurde @timothyvandenbrande @UnderGreen @ahtik @cyberark-bizdev @dhozac @drybjed @dsummersl @eikef @enunez-cyberark @erasmix @helldorado @joshainglis @karmab @machacekondra @mattclay @mwperina @ryansb @samdoran @tima
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 cloud docs This issue/PR relates to or includes documentation. identity Identity category module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. source_control Source-control category support:certified This issue/PR relates to certified code. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) labels Feb 18, 2019
@gundalow

This comment has been minimized.

Sign in to view
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Feb 18, 2019
@dagwieers dagwieers force-pushed the validate-modules-files branch 2 times, most recently from 04c5082 to 2ec946c Compare February 18, 2019 12:12
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Feb 18, 2019
samccann
samccann reviewed Feb 18, 2019
View reviewed changes
Copy link
Contributor

@samccann samccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor nit on the docs portion.

lib/ansible/modules/cloud/misc/virt_pool.py Outdated Show resolved Hide resolved
@ansibot

This comment has been minimized.

Sign in to view
@dagwieers dagwieers added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 18, 2019
@dagwieers
Copy link
Contributor Author

Because of a mixup between branches, this one included more than just the files-section of changes.
This has now been corrected.

@dagwieers
validate-modules: Fix some files modules
528efe0 
This PR includes:
- fixes to validate-modules issues

All modules already include parameter types.

The remaining files-modules have action plugins, so comparing to the arg_spec only is incorrect.
@ansibot ansibot removed the community_review In order to be merged, this PR must follow the community review workflow. label Feb 19, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed support:certified This issue/PR relates to certified code. support:community This issue/PR relates to code supported by the Ansible community. labels Feb 19, 2019
@dagwieers dagwieers removed cloud identity Identity category source_control Source-control category virt Virt community (incl. QEMU, KVM, libvirt, ovirt, RHV and Proxmox) labels Feb 25, 2019
@dagwieers dagwieers merged commit 3ced545 into ansible:devel Feb 25, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samccann samccann samccann left review comments

@gundalow gundalow gundalow approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dagwieers @ansibot @gundalow @samccann