Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMware: add missing fact about IP network in firewall facts #52554

Merged
merged 1 commit into from
Feb 25, 2019
Merged

VMware: add missing fact about IP network in firewall facts #52554

merged 1 commit into from
Feb 25, 2019

Conversation

Akasurde
Copy link
Member

SUMMARY

Fixes: #52526

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/vmware/vmware_host_firewall_facts.py

ADDITIONAL INFORMATION

After fix facts looks like -

...
{
                    "allowed_hosts": {
                        "all_ip": false,
                        "ip_address": [],
                        "ip_network": [
                            "11.111.112.0/22",
                            "192.168.10.1/24"
                        ]
                    },
                    "enabled": true,
                    "key": "sshClient",
                    "rule": [
                        {
                            "direction": "outbound",
                            "end_port": null,
                            "port": 22,
                            "port_type": "dst",
                            "protocol": "tcp"
                        }
                    ],
                    "service": null
                },
...

@Akasurde
VMware: add missing fact about IP network in firewall facts
09d8458 
Fixes: ansible#52526

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde Akasurde mentioned this pull request Feb 19, 2019
Closed
@ansibot
Copy link
Contributor

ansibot commented Feb 19, 2019

cc @ckotte @dav1x @lparkes @warthog9
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community labels Feb 19, 2019
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Feb 19, 2019
@Akasurde Akasurde merged commit c3777a6 into ansible:devel Feb 25, 2019
@Akasurde Akasurde deleted the i52526 branch February 25, 2019 17:13
@alongchamps
Copy link
Contributor

looks good to me

@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vmware_host_firewall_facts does not return networks, only individual IPs
3 participants
@Akasurde @ansibot @alongchamps