file module: Fixed missing prev_state == 'directory' in file

[figpope]

In a previous pull request I had submitted a change that fixed an issue with using force == True on directories and symlinks. However, I had thought that the oversight was just in the if statement. After trying the same command on the latest version of ansible, I'm encountering a missing case in the confirmation of change. I've added the missing case below.

[figpope]

Any comments on this? Right now this oversight leaves undefined behavior in the codebase.

[jctanner]

@drewlll2ll can you show me a way to reproduce the situation that this PR fixes?

[figpope]

@jctanner Try the following:

- name: Override directory with link
  file: state=link path=<existing directory> src=<directory to link from> force=yes

It produces

TASK: [vagrant | Link ubuntu user directory] **********************************
failed: [192.168.111.222] => {"dest": "/home/ubuntu", "failed": true, "gid": 1003, "group": "ubuntu", "item": "", "mode": "0755", "owner": "vagrant", "size": 4096, "src": "/home/vagrant", "state": "directory", "uid": 1000}
msg: unexpected position reached

[figpope]

@jctanner Any comments?

[figpope]

@jctanner Have you been able to reproduce this issue?

[jctanner]

@drewlll2ll looks good, thanks!