Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BOTMETA: Add $team_hcloud #52694

Merged
merged 2 commits into from
Mar 5, 2019
Merged

BOTMETA: Add $team_hcloud #52694

merged 2 commits into from
Mar 5, 2019

Conversation

dagwieers
Copy link
Contributor

SUMMARY

This adds support for the hcloud WG.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

hcloud

@dagwieers dagwieers mentioned this pull request Feb 21, 2019
Closed
@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Feb 21, 2019
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Feb 21, 2019
@dagwieers dagwieers added the botmeta This PR modifies the BOTMETA.yml and this requires special attention! label Feb 21, 2019
gundalow
gundalow previously requested changes Feb 22, 2019
View reviewed changes
Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On hold till lib/ansible/modules/cloud/hcloud/ has been created

@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Feb 27, 2019
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Feb 27, 2019
@LKaemmerling
Copy link
Contributor

I guess this could be merged too or am i wrong :)?

@dagwieers dagwieers merged commit a7eae0a into ansible:devel Mar 5, 2019
@dagwieers dagwieers removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 5, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gundalow gundalow gundalow left review comments

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 botmeta This PR modifies the BOTMETA.yml and this requires special attention! docs This issue/PR relates to or includes documentation. hcloud support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dagwieers @ansibot @LKaemmerling @gundalow @resmo