Fortinet FortiManager Module_Utils MINOR Update #52756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now accepts entire module as input, so it can use those data points for decisions later. This update is entirely related to our debugging and should have zero impact on existing modules.
ansibot
added
affects_2.8
ansibot
removed
the
needs_triage
…d error on last run.
ansibot
added
community_review
ansibot
added
the
stale_ci
…(which is only used by us, internally). It needs to be moved outside of the Ansible namespace so we can call it with try/catch without any other issues. Right now /ansible/executor/module_common.py runs w/ recursive_finder, and throws errors because it can't find debug on other machines within the ansible namespace. We don't have this issue with pyFMG legacy usage. So, we're disabling the code until we have a better way of calling this debug module. It isn't required for production usage.
ansibot
removed
the
stale_ci
NilashishC
approved these changes
Mar 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now accepts entire module as input, so it can use those data points for decisions later. This update is entirely related to our debugging and should have zero impact on existing modules.
SUMMARY
A minor update to our mod_utils to enable a streamlined debug process for capturing fixtures for unit tests. Has no impact on existing modules, very very small change that allows for the entire AnsibleModule object to be passed to it upon init, allowing for the passing of certain data points to our debug library.
Please approve with haste. Very minor update.
ISSUE TYPE
COMPONENT NAME
module_utils/network/fortimanager/fortimanager.py
ADDITIONAL INFORMATION