Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong Setup function was being used, which could result in failure if new global options were used. #52862

Merged
merged 5 commits into from
Mar 4, 2019
Merged

Wrong Setup function was being used, which could result in failure if new global options were used. #52862

merged 5 commits into from
Mar 4, 2019

Conversation

carchi8py
Copy link
Contributor

@carchi8py carchi8py commented Feb 22, 2019 •
edited

SUMMARY

Wrong Setup function was being used, which could result in failure if new global options were used.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • na_ontap_autosupport.py
  • na_ontap_flexcache.py
  • na_ontap_job_schedule.py
  • na_ontap_snapmirror.py
ADDITIONAL INFORMATION

@carchi8py
Revert "changes to clusteR"
e8dcea8 
This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.
@carchi8py
Revert "Revert "changes to clusteR""
1f257f7 
This reverts commit f1104a3.
@carchi8py
Revert "changes to clusteR"
5c014ef 
This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.
@carchi8py
Revert "Revert "changes to clusteR""
c3a4c49 
This reverts commit f1104a3.
@carchi8py
Fix setup bug
af2c8ef
@carchi8py carchi8py changed the title Wrong Setup function was being used, which could result in failure if new global option were used. Wrong Setup function was being used, which could result in failure if new global options were used. Feb 22, 2019
@ansibot
Copy link
Contributor

ansibot commented Feb 22, 2019

cc @amit0701 @hulquest @lmprice @lonico @ndswartz @schmots1
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. committer_review In order to be merged, this PR must follow the certified review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. netapp owner_pr This PR is made by the module's maintainer. storage support:certified This issue/PR relates to certified code. labels Feb 22, 2019
lonico
lonico approved these changes Feb 25, 2019
View reviewed changes
Copy link
Contributor

@lonico lonico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed committer_review In order to be merged, this PR must follow the certified review workflow. needs_triage Needs a first human triage before being processed. labels Feb 25, 2019
thedoubl3j
thedoubl3j approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@thedoubl3j thedoubl3j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could catch. lgtm

@gundalow gundalow merged commit ab22ea1 into ansible:devel Mar 4, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lonico lonico lonico approved these changes

@thedoubl3j thedoubl3j thedoubl3j approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. module This issue/PR relates to a module. netapp owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core storage support:certified This issue/PR relates to certified code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@carchi8py @ansibot @lonico @thedoubl3j @gundalow