Module nxos logging fixes

[mikewiebe]

SUMMARY

This PR fixes the follwing issues:

• Updates nxapi payloads to use an ordered dictionary to make sure the type and input fields are processed correctly.
  • Order should not matter but some versions of NX-OS software fail to process the payload properly if input gets serialized before type and the payload of input contains the word 'type'.
  • When this happens the command will not be applied to the nxos device.
• Fixes read_module_context and save_module_context functionality used currently by the nxos_logging module for purge capability. This worked previously for both network_cli and httapi but recent changes to module_utils/nxos.py broke the functionality for httpapi.
• Fixes an idempotence problem in nxos_logging for logging facilities when attempting to set the logging facility to the default value. The fix checks the playbook setting against the switch default value and does not configure it if it's already in the default state.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

nxos_logging

Changes tested against a comprehensive matrix of Nexus devices and image versions.

[ansibot]

cc @NilashishC @Qalthos @chrisvanheuveln @ganeshrn @gdpak @justjais @rahushen @rcarrillocruz @trishnaguha
click here for bot help

[ansibot]

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/modules/network/nxos/nxos_logging.py:334:13: too-many-format-args Too many arguments for format string
lib/ansible/modules/network/nxos/nxos_logging.py:335:22: ansible-format-automatic-specification Format string contains automatic field numbering specification

click here for bot help

[mikewiebe]

@Qalthos Any update on this PR? Thanks!

[sumkincpp]

Simply return self._module_context.get(module_key) will do the trick!