Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New module - meraki_nat #52889

Merged
merged 13 commits into from
Jul 26, 2019
Merged

New module - meraki_nat #52889

merged 13 commits into from
Jul 26, 2019

Conversation

kbreit
Copy link
Contributor

@kbreit kbreit commented Feb 24, 2019 •
edited

SUMMARY

Meraki added support for NAT objects in the API. This module allows for querying and manipulating 1:1 rules, 1:many rules, and port forwarding rules.

Depends on #48394 (merged)

Fixes #52874

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

meraki_nat

@ansibot
Copy link
Contributor

ansibot commented Feb 24, 2019

cc @dagwieers
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 community_review In order to be merged, this PR must follow the community review workflow. meraki Cisco Meraki community module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels Feb 24, 2019
@kbreit kbreit changed the title New module - meraki_nat [WIP] New module - meraki_nat Feb 24, 2019
@ansibot ansibot added the WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. label Feb 24, 2019
@dagwieers dagwieers added the cisco Cisco technologies label Feb 27, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Mar 2, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 11, 2019
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 18, 2019
@kbreit
Initial commit for meraki_nat module
747194a 
- Query fully works
- Present is still very much in development
@kbreit
Add initial code for present functionality, not complete
4c920c6
@kbreit
Add request documentation
b8301d2
@kbreit
Add examples and return documentation.
454443e
@kbreit
Added payload to requests
6e5fd81 
- Module seems to need new idempotency check
@kbreit
Allow 1:1 and 1:many NAT to work
c94c267 
- New idempotency check method is probably required to work
@kbreit
Make all three options work
fe7d18e 
- Module isn't idempotent
@kbreit
Diff support
17fba7e 
- Added integration tests
- Diff support isn't quite done
@kbreit
Fix diff output
0678c99
@kbreit kbreit changed the title [WIP] New module - meraki_nat New module - meraki_nat May 30, 2019
@kbreit
Copy link
Contributor Author

kbreit commented May 30, 2019

ready_for_review

@ansibot ansibot removed the WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. label May 30, 2019
@kbreit kbreit changed the title New module - meraki_nat [WIP] New module - meraki_nat May 30, 2019
@kbreit kbreit changed the title [WIP] New module - meraki_nat New module - meraki_nat May 30, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 7, 2019
@kbreit kbreit mentioned this pull request Jun 12, 2019
Closed
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jun 19, 2019
@kbreit
Update documentation and tests
bfb5537 
- Split tests to separate file to avoid delegate_to
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 20, 2019
@kbreit
Copy link
Contributor Author

kbreit commented Jun 20, 2019

@Qalthos I've updated this one based on your suggestions. Please review.

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 28, 2019
@ansibot ansibot added the stale_review Updates were made after the last review and the last review is more than 7 days old. label Jul 6, 2019
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. has_issue and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Jul 24, 2019
@pabelanger pabelanger merged commit f8f3986 into ansible:devel Jul 26, 2019
@ansible ansible locked and limited conversation to collaborators Aug 26, 2019
@kbreit kbreit deleted the meraki/meraki_nat branch November 28, 2019 20:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Qalthos Qalthos Qalthos approved these changes

@pabelanger pabelanger pabelanger approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 cisco Cisco technologies community_review In order to be merged, this PR must follow the community review workflow. has_issue meraki Cisco Meraki community module This issue/PR relates to a module. networking Network category new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New module - meraki_nat
5 participants
@kbreit @ansibot @Qalthos @pabelanger @dagwieers